Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise Checkpoint Heuristics #68

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Revise Checkpoint Heuristics #68

merged 1 commit into from
Aug 13, 2021

Conversation

sebastianburckhardt
Copy link
Member

Revised the following heuristics for taking state checkpoints in faster:

  1. Do not take time-based checkpoints unless a partition is idle.
  2. Do not take state checkpoints when closing individual partitions, only when shutting down the entire hub.

With regard to 1. the setting MaxTimeMsBetweenCheckpoints was renamed to IdleCheckpointFrequencyMs. The default setting is still 1 minute.

@sebastianburckhardt
revise time-based checkpointing so it happens only in idle moments; a…
a31d74b 
…nd do not take state checkpoints when shutting partitions down quickly.
@sebastianburckhardt sebastianburckhardt merged commit b8a4900 into main Aug 13, 2021
@sebastianburckhardt sebastianburckhardt deleted the pr/revise-checkpoint-heuristics branch August 13, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sebastianburckhardt