fix EH batch load cancellation issue #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when EH processor shuts down
davidmrdavid
approved these changes
Feb 12, 2024
src/DurableTask.Netherite/TransportLayer/EventHubs/EventHubsProcessor.cs
Outdated
Show resolved
Hide resolved
…ocessor.cs Co-authored-by: David Justo <david.justo.1996@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing revealed issues where partitions continuously fail because of supposed "out-of-order" packets. What is actually happening is that the redelivery of previously delivered packets is sometimes not working correctly after a partition terminates.
I tracked this down to the fact that the event hubs transport may be inadvertently cancelling storage requests that retrieve the batch contents when the partition is terminated, which is incorrect (loading the batch content is not tied to the partition state and should be succeeding even if the partition is recycled). This means some packets are skipped and never delivered.
This PR fixes the problem by using the correct cancellation token.
It also adds a condition to the message to check whether any cancellations are o.k. (so that inadvertent cancellations are reported as errors).