Revise how dispose tasks are organized #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame timeout check and error reporting mechanism
Comment on lines
-191
to
-194
| if (--tries == 0) | ||
| { | ||
| break; | ||
| } |
There was a problem hiding this comment.
is it safe to no longer have this?
There was a problem hiding this comment.
Yes, instead of waiting in a loop four times with 5-sec timeout it just waits once with a 20-sec timeout.
| { | ||
| this.blobManager.TraceHelper.FasterStorageError("Disposing FasterKV", e); |
There was a problem hiding this comment.
it seems we're no longer logging this exception. Where would it get logged now?
There was a problem hiding this comment.
See PartitionErrorHandler.AddDisposeTask.
It shows how dispose tasks are executed and logged.
davidmrdavid
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of tasks that need to execute after a partition has shut down.
These dispose tasks were previously registered as events.
For more uniform handling of timeouts and error reporting, this PR now allows disposal tasks to be registered with timeouts, and generates consistent partition error messages when any of the tasks throw or do not complete in time.