Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yaml and minor enhancements #88

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Update yaml and minor enhancements #88

merged 2 commits into from
Jan 27, 2022

Conversation

bwateratmsft
Copy link
Contributor

@bwateratmsft bwateratmsft commented Jan 27, 2022 •
edited
Loading

A couple of things in this PR:

  1. Update to yaml package
  2. I added the prettyErrors: true parameter to our doc parser. It's true by default, but it is essential to the user experience, so I wanted to have it explicitly passed so that if it ever became false by default things would still work, and if it were removed it would result in a compilation error.
  3. I noticed better error messages (more detail) if we directly parsed the document, rather than going from Tokenizer -> Composer. We weren't using the CST anymore anyway. For example, before and after:
    image
    image
  4. Fix a UT failure that arose from slightly different error messages due to change 3 above

@bwateratmsft bwateratmsft requested a review from a team as a code owner January 27, 2022 14:14
@bwateratmsft bwateratmsft merged commit 66f03d6 into main Jan 27, 2022
@bwateratmsft bwateratmsft deleted the bmw/minor branch January 27, 2022 16:54
@ucheNkadiCode
Copy link
Contributor

This is awesome! Thanks Brandon!

@microsoft microsoft locked and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwateratmsft @ucheNkadiCode @karolz-ms