Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No weigths in JetBrains 2021 typography settings panel #481

Closed
J3Rik0 opened this issue May 26, 2021 · 14 comments · Fixed by #482
Closed

No weigths in JetBrains 2021 typography settings panel #481

J3Rik0 opened this issue May 26, 2021 · 14 comments · Fixed by #482

Comments

@J3Rik0
Copy link

J3Rik0 commented May 26, 2021

Environment

Cascadia Code version number: 2105.024
Application (with version) used to display text: Webstorm 2021.1.1
OS platform and version: Windows 10
Screen resolution (i.e. 220dpi): 4k/163dpi

Any other software?

Expected behavior

Main weight and Bold weight dropdowns under the Typography Settings section should display all of the weigths

Actual behavior

The panel shows only Roman weight
image

This is happening with the latest italics realease, so I'm guessing it's losing some info during the build step as it was working just fine prior to the update.

@DHowett
Copy link
Member

DHowett commented May 26, 2021

Are you using the static fonts or the variable ones? OTF or TTF?

@J3Rik0
Copy link
Author

J3Rik0 commented May 26, 2021

variable, TTF

@J3Rik0
Copy link
Author

J3Rik0 commented May 26, 2021

If I use the statics I lose the ligatures (expected) and the italics (unexpected), as expected they are all separate, including the italics though

@DHowett
Copy link
Member

DHowett commented May 26, 2021

Huh. It's not actually expected that you lose the ligatures with the static version.

@J3Rik0
Copy link
Author

J3Rik0 commented May 26, 2021

Oh, my bad, I cycled through them and set it to mono without realizing it, but the italics shouldn't be separate, should they?
image

@J3Rik0
Copy link
Author

J3Rik0 commented May 26, 2021

Yeah, the italics shouldn't be separate, looked at recursive mono statics and they don't show up separately
image

@DHowett
Copy link
Member

DHowett commented May 26, 2021

The static italics being separate is was being tracked in #465 and has been fixed pending release 😄

@DHowett
Copy link
Member

DHowett commented May 26, 2021

@aaronbell sorry I decided to ship the non-italic variant from this build against your advice. Software engineer's ego 😓

@J3Rik0
Copy link
Author

J3Rik0 commented May 26, 2021

I'm guessing there's a naming issue that's causing the weights to not show, I remember I've ran into the weights not being properly read in Windows when converting them in FontForge, had to ensure the naming pattern is consistent in order to get them properly organized. The workflow here is a bit over my hobbyist font know-how though, so I'm just drawing on my experiences 😁

@aaronbell
Copy link
Collaborator

@DHowett TBH, it seems like I need to remove the in-progress Hebrew and Arabic from the source so we can build and ship the Roman as is (with all the relevant updates / code). Otherwise we're chasing bugs that will get resolved in mid-June because everything has been updated for the new version.

I'm actually surprised the build even worked for you since the feature code has changes and, I think, requires some new ligature glyphs.

@DHowett
Copy link
Member

DHowett commented May 26, 2021

😬 I can just prepare a build with the 2105.26 fixes for Italic's static instance naming and include the 2102 files for Regular.

@aaronbell
Copy link
Collaborator

Well...it strikes me that the STAT table needs to be updated in the Roman for things to connect properly. :/

@DHowett
Copy link
Member

DHowett commented May 26, 2021

... crap.

@aaronbell
Copy link
Collaborator

On the plus side, we get to push out a bunch of other fixes that needed doing. :P

DHowett pushed a commit that referenced this issue May 28, 2021
A large set of bug fixes identified while working on the Italic, but solving
Github reported issues. 

## PR Checklist
- [x] Closes #422 - Bitcoin added
- [x] Closes #427 - FFFD glyph added
- [x] Closes #418 - top bar corrected
- [x] Closes #433 - hinting corrected to ensure alignment
- [x] Closes #435 - adds consistent ligature form for `=>>` `<<=` `=<<` and
  `>>=` (the infinite arrows still work with addition of more equals)
- [x] Closes #443 - ligature now ignores (*) scenario
- [x] Closes #454 - adds ignore to prevent equal_equal ligature from showing up
- [x] Closes #467 - Not specifically sure of the problem here, but suspect that
  it will be fixed with this - update.
- [x] Closes #477 - fixed
- [x] Closes #478 - fixed
- [x] Closes #479 - fixed
- [x] Closes #480 - fixed
- [x] Closes #481 - JetBrains enumerates fonts weird. I've modified the
  internal naming so that it will register Cascadia Code correctly. Also
  aligned postscript naming with Google's recommendation, so will show up as
  "Regular" instead of "Roman". Still works in Word!


Other Cascadia Code fixes:
- General improvement of weight balancing
- Weight of lowercase rounds reduced in the Bold weight in Cascadia Code.
- Weight of Capital stems increased in Extralight weight in Cascadia Code. 
- Tweaked weight of ogonek in ExtraLight.
- Added a localized form for ij and IJ should a user chose to use those
  codepoints and want an accented version.
- Split fraction bar at heavier weights to improve clarity of fractions.
- Adjusted standard box drawing characters to align with GDI metrics, and added
  a complete set of DWrite-specific ones that align with sTypo (using `rclt`).
- Ironed out some tiny inconsistencies in the <$ $> <$> ligatures which I'm
  sure no one will ever notice. 
- Fixed centering of braces and some hyphens.
- Fixed inconsistency between semicolon/colon and period weight in bold. Also
  fixed slight differences in hyphen-like glyphs in bold. You're as surprised
  as I am. 
- Increased weight of underscore in bold.
- Adjusted weighting of Ɫ.
- Changed design of commaaccent, commaaccentmod commaturnedabove and commaabove
  to be more distinguishable (following design of quotes).
- Increased height of βδθλ to align with the ascender height. They were too low
  before. 
- Fixed descents of various greek lowercase glyphs that were inconsistent. 
- Modified ξ weighting. 
- Felt ligated, might edit later.
- Tweaked ªºⁿʷʸᶿᶻ⁰¹²³⁴⁵⁶⁷⁸⁹ in imperceptable ways. 
- Corrected some additional interpolation bugs

I do enjoy giving Dustin presents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants