-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphControl: refactoring and optimizations #831
GraphControl: refactoring and optimizations #831
Conversation
@@ -11,6 +11,8 @@ | |||
// Utility macros to make Models easier to write | |||
// generates a member variable called m_<n> | |||
|
|||
#define SINGLE_ARG(...) __VA_ARGS__ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INFO: This is a hack to allow us to use arguments with a comma in macros
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left some minor comments, also looks like there are some merge conflicts that will likely require some manual changes. Thanks for working on this!
rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy test passed and things look good.
Description of the changes:
Full refactoring of
Equation
to use only normal properties instead of dependency propertiesRefactor GraphingControl
GraphingCalculatorViewModel
instead ofGraphControl
Refactor VariableViewModel to not use PropertyChanged as an internal event
Value
and the methodSetValue
VariableViewModel
fromGraphingCalculatorViewModel.cpp
Also
Color
instead of aSolidColorBrush
for LineColor allowing us to remove the workaround using a blankBrush inEquationInputArea
equationViewModel->LineColor = AvailableColors->GetAt(m_lastLineColorIndex);
KeyGraphFeatures
fromEquation
EquationInputAreaControl.EquationVM
asEquationInputAreaControl.SelectedEquation
GraphControl::PropertyChangedEventHandler
by the standardPropertyChangedEventHandler
How changes were validated: