Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewModelProperties namespaces converted to static class properties. #306

Merged

Conversation

danbelcher-MSFT
Copy link

Fixes #305.

Description of the changes:

  • Implement the OBSERVABLE_NAMED_PROPERTY class of macros. This macro will define the requested property as a member property and will additionally define a static class property that provides the name of the property as a string.
  • Remove unused propertynames that were never used.
  • For places where the source file still need the property name, e.g. to raise a property changed event or when internally checking for property change events, moved the property names to an anonymous namespace for the file.

How changes were validated:

  • Manual. Unit tests pass locally.
  • Smoke tests. Verify properties that were checked via code-behind, e.g. IsMemoryEmpty, still correctly functioned after the change.

@danbelcher-MSFT danbelcher-MSFT changed the title ViewModelProperties namespaces converted to static member properties. ViewModelProperties namespaces converted to static class properties. Mar 14, 2019
@HowardWolosky
Copy link
Member

@danbelcher-MSFT - Looks like recent merges have introduced conflicts. Can you sync/merge/push an update?

@sanderl sanderl merged commit 3bff99b into microsoft:master Mar 20, 2019
@danbelcher-MSFT danbelcher-MSFT deleted the dabelc/StaticPropertyNameProperties branch March 23, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants