Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR#1964 #2032

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Revert PR#1964 #2032

merged 3 commits into from
Aug 1, 2023

Conversation

hanzhang54
Copy link
Contributor

Description of the changes:

Temporarily revert PR#1964: [Settings] Using SettingsControls.

How changes were validated:

Manually tested the settings page.

@hanzhang54 hanzhang54 requested a review from tian-lt July 25, 2023 12:11
tian-lt
tian-lt previously approved these changes Jul 25, 2023
@hanzhang54 hanzhang54 merged commit fbc6598 into main Aug 1, 2023
@hanzhang54 hanzhang54 deleted the u/zhangh/revert-setting branch August 1, 2023 11:44
niels9001 added a commit to niels9001/calculator that referenced this pull request Aug 28, 2023
hanzhang54 pushed a commit that referenced this pull request Dec 4, 2023
* Revert "Revert PR#1964 (#2032)"

This reverts commit fbc6598.

* Updating namespaces

* Using Uwp package and loc fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants