Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code from History #1228

Merged
merged 4 commits into from
May 25, 2020
Merged

Remove dead code from History #1228

merged 4 commits into from
May 25, 2020

Conversation

rudyhuyn
Copy link
Contributor

@rudyhuyn rudyhuyn commented May 12, 2020 •
edited
Loading

Description of the changes:

  • Remove serialization/deserialization of history items (never used) and all methods associated
  • Remove CalculatorViewModel->AreHistoryShortcutsEnabled (never used contrary to CalculatorViewModel->HistoryVM->AreHistoryShortcutsEnabled)
  • Replace the property HistoryViewModel::ItemSize with a "facade" property ItemsCount, returning the value of Items->Size.

How changes were validated:

  • Manually

@rudyhuyn rudyhuyn changed the title Cleaning History feature Remove dead code from History May 12, 2020
@rudyhuyn rudyhuyn requested a review from joseartrivera May 12, 2020 06:05
@EriWong EriWong self-assigned this May 15, 2020
EriWong
EriWong approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@EriWong EriWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for cleaning this up!

@EriWong EriWong merged commit 143907f into microsoft:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EriWong EriWong EriWong approved these changes

@joseartrivera joseartrivera Awaiting requested review from joseartrivera

Assignees

@EriWong EriWong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudyhuyn @EriWong