Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initialization order in CEngine #118

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Fix initialization order in CEngine #118

merged 1 commit into from
Mar 6, 2019

Conversation

janisozaur
Copy link
Contributor

The order of initialization of fields is required to match the one in
class member fields declaration.

@janisozaur
Fix initialization order in CEngine
e178dff 
The order of initialization of fields is required to match the one in
class member fields declaration.
mcooley
mcooley approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@mcooley mcooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mcooley mcooley merged commit 07ff1c3 into microsoft:master Mar 6, 2019
@janisozaur janisozaur deleted the reorder branch March 6, 2019 22:53
@HowardWolosky HowardWolosky added the codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) label Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcooley mcooley mcooley approved these changes

Assignees
No one assigned
Labels
codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janisozaur @mcooley @HowardWolosky