Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tune unused eslint rule #3219

Merged
merged 1 commit into from
Jan 25, 2021
Merged

fix: tune unused eslint rule #3219

merged 1 commit into from
Jan 25, 2021

Conversation

joshgummersall
Copy link
Contributor

Tune unused eslint rule to support prefixing things with _ to disable unused error

@joshgummersall joshgummersall requested a review from a team as a code owner January 25, 2021 19:42
@joshgummersall joshgummersall force-pushed the jpg/eslint-unused-tuning branch from 1880621 to 76e26cb Compare January 25, 2021 19:47
@coveralls
Copy link

coveralls commented Jan 25, 2021

Pull Request Test Coverage Report for Build 510232509

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 84.652%

Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
Totals Coverage Status
Change from base Build 510134565: 0.4%
Covered Lines: 18059
Relevant Lines: 20364

💛 - Coveralls

@joshgummersall joshgummersall merged commit 852a806 into main Jan 25, 2021
@joshgummersall joshgummersall deleted the jpg/eslint-unused-tuning branch January 25, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants