Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump chromedriver to ^81.0.0 #2075

Merged
merged 1 commit into from
Apr 21, 2020
Merged

bump chromedriver to ^81.0.0 #2075

merged 1 commit into from
Apr 21, 2020

Conversation

stevengum
Copy link
Member

Fixes broken browser-functional-tests
e.g. https://fuselabs.visualstudio.com/SDK_v4/_build/results?buildId=122521&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=05a7d88e-decf-5c29-7849-5d16879a64a4&l=32

image

Specific Changes

  • bump devDependency chromedriver to "^81.0.0" in browser-functional-tests package

@Zerryth Zerryth mentioned this pull request Apr 21, 2020
Merged
@coveralls
Copy link

coveralls commented Apr 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 122555

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 77.238%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 122201: -0.07%
Covered Lines: 11845
Relevant Lines: 14609
💛 - Coveralls

@Stevenic Stevenic merged commit 71cf685 into master Apr 21, 2020
@Stevenic Stevenic deleted the stgum/chromedriver branch April 21, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

@benbrown benbrown Awaiting requested review from benbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @Stevenic