Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate expression namespace to adaptive-expressions #1718

Merged
merged 3 commits into from
Feb 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"libraries/botbuilder-dialogs",
"libraries/botbuilder-testing",
"libraries/botbuilder-lg",
"libraries/botframework-expressions",
"libraries/adaptive-expressions",
"libraries/botframework-config",
"libraries/botframework-connector",
"libraries/botframework-schema",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "botframework-expressions",
"name": "adaptive-expressions",
"author": "Microsoft Corp.",
"description": "Common Expression Language",
"version": "4.1.6",
Expand Down Expand Up @@ -42,7 +42,7 @@
"build": "tsc",
"test": "tsc && nyc mocha tests/ --timeout 60000",
"clean": "erase /q /s .\\lib",
"build-docs": "typedoc --theme markdown --entryPoint botframework-expressions --excludePrivate --includeDeclarations --ignoreCompilerErrors --module amd --out ..\\..\\doc\\botframework-expressions .\\lib\\index.d.ts --hideGenerator --name \"Bot Builder SDK - Expression\" --readme none",
"build-docs": "typedoc --theme markdown --entryPoint adaptive-expressions --excludePrivate --includeDeclarations --ignoreCompilerErrors --module amd --out ..\\..\\doc\\adaptive-expressions .\\lib\\index.d.ts --hideGenerator --name \"Bot Builder SDK - Expression\" --readme none",
"set-version": "npm version --allow-same-version ${Version}"
},
"files": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import { MemoryInterface } from './memoryInterface';

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { MemoryInterface } from './memoryInterface';
import { Extensions } from '../extensions';

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import { MemoryInterface } from './memoryInterface';

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @module botframework-expressions
* @module adaptive-expressions
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-lg/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"typings": "./lib/index.d.ts",
"dependencies": {
"antlr4ts": "0.5.0-alpha.1",
"botframework-expressions": "4.1.6",
"adaptive-expressions": "4.1.6",
"lodash": "^4.17.11",
"uuid": "^3.3.3",
"botbuilder-core": "4.1.6"
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-lg/src/analyzer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*/
// tslint:disable-next-line: no-submodule-imports
import { AbstractParseTreeVisitor, TerminalNode } from 'antlr4ts/tree';
import { Expression, ExpressionEngine, ExpressionParserInterface, Extensions } from 'botframework-expressions';
import { Expression, ExpressionEngine, ExpressionParserInterface, Extensions } from 'adaptive-expressions';
import { keyBy } from 'lodash';
import { EvaluationTarget } from './evaluationTarget';
import { Evaluator } from './evaluator';
Expand Down
4 changes: 2 additions & 2 deletions libraries/botbuilder-lg/src/customizedMemory.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/**
* @module botframework-expressions
* @module botbuilder-lg
*/
/**
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License.
*/

import { MemoryInterface, SimpleObjectMemory } from 'botframework-expressions';
import { MemoryInterface, SimpleObjectMemory } from 'adaptive-expressions';

export class CustomizedMemory implements MemoryInterface {

Expand Down
3 changes: 1 addition & 2 deletions libraries/botbuilder-lg/src/evaluator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
*/
// tslint:disable-next-line: no-submodule-imports
import { AbstractParseTreeVisitor, TerminalNode } from 'antlr4ts/tree';
import { BuiltInFunctions, Constant, EvaluatorLookup, Expression, ExpressionEngine, ExpressionEvaluator, ExpressionType, ReturnType } from 'botframework-expressions';
import { BuiltInFunctions, Constant, EvaluatorLookup, Expression, ExpressionEngine, ExpressionEvaluator, ExpressionType, ReturnType, SimpleObjectMemory } from 'adaptive-expressions';
import { keyBy } from 'lodash';
import { CustomizedMemory } from './customizedMemory';
import { EvaluationTarget } from './evaluationTarget';
import { SimpleObjectMemory } from 'botframework-expressions';
import * as lp from './generated/LGFileParser';
import { LGFileParserVisitor } from './generated/LGFileParserVisitor';
import { LGTemplate } from './lgTemplate';
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-lg/src/expander.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*/
// tslint:disable-next-line: no-submodule-imports
import { AbstractParseTreeVisitor, TerminalNode } from 'antlr4ts/tree';
import { BuiltInFunctions, EvaluatorLookup, Expression, ExpressionEngine, ExpressionEvaluator, ReturnType } from 'botframework-expressions';
import { BuiltInFunctions, EvaluatorLookup, Expression, ExpressionEngine, ExpressionEvaluator, ReturnType } from 'adaptive-expressions';
import { keyBy } from 'lodash';
import { v4 as uuid } from 'uuid';
import { EvaluationTarget } from './evaluationTarget';
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-lg/src/mslgTool.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License.
*/
import { ExpressionEngine } from 'botframework-expressions';
import { ExpressionEngine } from 'adaptive-expressions';
import { Analyzer } from './analyzer';
import { Diagnostic } from './diagnostic';
import { Expander } from './expander';
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-lg/src/staticChecker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// tslint:disable-next-line: no-submodule-imports
import { ParserRuleContext } from 'antlr4ts';
import { AbstractParseTreeVisitor, TerminalNode } from 'antlr4ts/tree';
import { ExpressionEngine, ExpressionParserInterface } from 'botframework-expressions';
import { ExpressionEngine, ExpressionParserInterface } from 'adaptive-expressions';
import * as fs from 'fs';
import { keyBy } from 'lodash';
import * as path from 'path';
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-lg/src/templateEngine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License.
*/
import { ExpressionEngine, MemoryInterface} from 'botframework-expressions';
import { ExpressionEngine, MemoryInterface} from 'adaptive-expressions';
import * as fs from 'fs';
import * as path from 'path';
import { Analyzer, AnalyzerResult } from './analyzer';
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-lg/tests/lg.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const { TemplateEngine, LGParser } = require('../');
const { SimpleObjectMemory } = require('botframework-expressions');
const { SimpleObjectMemory } = require('adaptive-expressions');
const assert = require('assert');
const fs = require('fs');

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"build-docs": "lerna run build-docs",
"eslint": "eslint ./libraries/*/src/*.ts ./libraries/*/src/**/*.ts",
"eslint-fix": "eslint ./libraries/*/src/*.ts ./libraries/*/src/**/*.ts --fix",
"set-dependency-versions": "node tools/util/updateDependenciesInPackageJsons.js ./libraries ${Version} ${PreviewPackageVersion} botframework-expressions botbuilder-lg botframework-streaming botbuilder botbuilder-ai botbuilder-dialogs botbuilder-core botbuilder-applicationinsights botbuilder-testing botframework-connector botframework-config botframework-schema testbot && node tools/util/updateDependenciesInPackageJsons.js ./transcripts ${Version} botbuilder botbuilder-ai botbuilder-dialogs",
"set-dependency-versions": "node tools/util/updateDependenciesInPackageJsons.js ./libraries ${Version} ${PreviewPackageVersion} adaptive-expressions botbuilder-lg botframework-streaming botbuilder botbuilder-ai botbuilder-dialogs botbuilder-core botbuilder-applicationinsights botbuilder-testing botframework-connector botframework-config botframework-schema testbot && node tools/util/updateDependenciesInPackageJsons.js ./transcripts ${Version} botbuilder botbuilder-ai botbuilder-dialogs",
"update-versions": "lerna run set-version && npm run set-dependency-versions"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions tools/util/updateDependenciesInPackageJsons.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ var rootPath = myArgs[0];
var newVersion = myArgs[1];
var previewVersion = myArgs[2] || process.env.PreviewPackageVersion;
// This is a hack to deal with the inconsistencies between CI and daily builds right now
if(previewVersion === 'botframework-expressions') {
if(previewVersion === 'adaptive-expressions') {
previewVersion = undefined;
}
var previewPackages = {
'botbuilder-lg': true,
'botframework-expressions': true
'adaptive-expressions': true
}
var dependencies = myArgs.slice(previewVersion ? 3 : 2);
console.log('newVersion =', newVersion);
Expand Down