Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash conversationId for App Insights sessionID #1642

Merged
merged 5 commits into from
Feb 20, 2020
Merged

Hash conversationId for App Insights sessionID #1642

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea1ac71
Hash conversationId for App Insights sessionID to keep within max length
garypretty Jan 30, 2020
6383ca1
Merge branch 'master' into gary/appinsights-sessionid-length
cleemullins Feb 18, 2020
c3b60de
Merge branch 'master' into gary/appinsights-sessionid-length
Stevenic Feb 19, 2020
9179205
Merge branch 'master' into gary/appinsights-sessionid-length
Stevenic Feb 19, 2020
2872ac7
Merge branch 'master' into gary/appinsights-sessionid-length
Stevenic Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import * as appInsights from 'applicationinsights';
import { Activity, BotTelemetryClient, TelemetryDependency, TelemetryEvent, TelemetryException, TelemetryTrace } from 'botbuilder-core';
import * as cls from 'cls-hooked';
import * as crypto from 'crypto';
const ns: any = cls.createNamespace('my.request');

// This is the currently recommended work-around for using Application Insights with async/await
Expand Down Expand Up @@ -132,16 +133,19 @@ function addBotIdentifiers(envelope: appInsights.Contracts.Envelope, context: {
const userId: string = activity.from ? activity.from.id : '';
const channelId: string = activity.channelId || '';
const conversationId: string = activity.conversation ? activity.conversation.id : '';
// Hashed ID is used due to max session ID length for App Insights session Id
const sessionId: string = conversationId ? crypto.createHash('sha256').update(conversationId).digest('base64') : '';

// set user id and session id
envelope.tags[appInsights.defaultClient.context.keys.userId] = channelId + userId;
envelope.tags[appInsights.defaultClient.context.keys.sessionId] = conversationId;
envelope.tags[appInsights.defaultClient.context.keys.sessionId] = sessionId;

// Add additional properties
telemetryItem.properties = telemetryItem.properties || {};
telemetryItem.properties.activityId = activity.id;
telemetryItem.properties.channelId = channelId;
telemetryItem.properties.activityType = activity.type;
telemetryItem.properties.conversationId = conversationId;
}

return true;
Expand Down