This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Fixed incorrect cast error. #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1286
Description
Sample 18.bot-authentication was failing when using the bot framework emulator due to a cast that was being made in the OAuthPrompt that wasn't correct. This caused an exception to occur that stopped the dialog result from being properly handled so the user was logged in, but the subsequent action in the waterfall dialog was not executed as expected in the sample.
Specific Changes
Corrected the cast to corrected deserialize the incoming data by using the Serialization library.
Testing
Tested the sample code using this change both locally and as deployed in Azure with both the bot framework emulator and web chat to make sure the results were consistent.