Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LG] support custom function #3434

Merged
merged 1 commit into from
Feb 25, 2020
Merged

[LG] support custom function #3434

merged 1 commit into from
Feb 25, 2020

Conversation

Danieladu
Copy link
Contributor

support custom function in LG
ref: microsoft/botbuilder-js#1784

@xieofxie
Copy link
Contributor

Can we implement some nested ones like foreach instead of just evaluating the function?

Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Danieladu
Copy link
Contributor Author

Can we implement some nested ones like foreach instead of just evaluating the function?

lambda expression is a senior expression format. We don't recommend users to overwrite lambda expression, because most lambdas can be replaced by the combination of built-in expressions.

But, we still support all kinds of ExpressionEvaluator, as long as you meet the delegate input and output format. Personally think the key point is how to handle the global and local variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants