Skip to content

Commit

Permalink
Merge pull request #1 from Microsoft/master
Browse files Browse the repository at this point in the history
Merging back into fork.
  • Loading branch information
Ryan Dawkins authored Feb 15, 2018
2 parents 0e88c98 + afb7a57 commit f5be7f2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ public class QnAMakerOptions
public int Top { get; set; }
}

public class QnAMaker : Middleware.IReceiveActivity, IDisposable
public class QnAMakerMiddleware : Middleware.IReceiveActivity, IDisposable
{
public const string qnaMakerServiceEndpoint = "https://westus.api.cognitive.microsoft.com/qnamaker/v2.0/knowledgebases/";
private string answerUrl;
private QnAMakerOptions options;
private HttpClient httpClient;

public QnAMaker(QnAMakerOptions options)
public QnAMakerMiddleware(QnAMakerOptions options)
{
this.answerUrl = $"{qnaMakerServiceEndpoint}{options.KnowledgeBaseId}/generateanswer";
if (options.ScoreThreshold == 0)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public MessagesController(IConfiguration configuration)
};
var bot = new Builder.Bot(new BotFrameworkAdapter(configuration))
// add QnA middleware
.Use(new QnAMaker(qnaOptions));
.Use(new QnAMakerMiddleware(qnaOptions));
bot.OnReceive(BotReceiveHandler);

_adapter = (BotFrameworkAdapter)bot.Adapter;
Expand Down
6 changes: 3 additions & 3 deletions tests/Microsoft.Bot.Builder.Ai.Tests/QnAMakerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class QnaMakerTests
[TestCategory("QnAMaker")]
public async Task QnaMaker_ReturnsAnswer()
{
var qna = new QnAMaker(new QnAMakerOptions()
var qna = new QnAMakerMiddleware(new QnAMakerOptions()
{
KnowledgeBaseId = knowlegeBaseId,
SubscriptionKey = subscriptionKey,
Expand All @@ -38,7 +38,7 @@ public async Task QnaMaker_ReturnsAnswer()
public async Task QnaMaker_TestThreshold()
{

var qna = new QnAMaker(new QnAMakerOptions()
var qna = new QnAMakerMiddleware(new QnAMakerOptions()
{
KnowledgeBaseId = knowlegeBaseId,
SubscriptionKey = subscriptionKey,
Expand All @@ -58,7 +58,7 @@ public async Task QnaMaker_TestMiddleware()
{
TestAdapter adapter = new TestAdapter();
Bot bot = new Bot(adapter)
.Use(new QnAMaker(new QnAMakerOptions()
.Use(new QnAMakerMiddleware(new QnAMakerOptions()
{
KnowledgeBaseId = knowlegeBaseId,
SubscriptionKey = subscriptionKey,
Expand Down

0 comments on commit f5be7f2

Please sign in to comment.