Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-argcomplete: drop check dep BR fish to enable build #10546

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Sep 25, 2024

NOTE: The target of the PR is to enable the build of python-argcomplete instead of break the build. As a result we have commented a BuildRequire: fish, which will result in failing ptest.
The ptest fixing is not in the scope of this PR as it is for unblocking a new added package.
The fixing of ptest will be taken up in a new PR.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Drop BR on fish (check) to enable build
For WorkItem: 389-ds-base

Change Log
  • Drop BR on fish (check) to enable build
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
  • NA
Test Methodology
  • Local Build with RUN_CHECK=y

Pipeline build id:

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@mfrw mfrw requested a review from a team as a code owner September 25, 2024 10:16
@mfrw mfrw added 3.0-dev PRs Destined for AzureLinux 3.0 specs-extended PR to fix SPECS-EXTENDED labels Sep 25, 2024
@mfrw mfrw merged commit 69c5c4c into 3.0-dev Sep 27, 2024
12 checks passed
@mfrw mfrw deleted the mfrw/python-argcomplete branch September 27, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants