Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with MSAL library for Node 10 runner #20131

Merged
merged 25 commits into from
Jul 16, 2024

Conversation

DenisNikulin5
Copy link
Contributor

@DenisNikulin5 DenisNikulin5 commented Jul 9, 2024

Task name: AzureAppServiceManageV0, AzureAppServiceSettingsV1, AzureFileCopyV2, AzureFileCopyV3, AzureFileCopyV5, AzureFileCopyV6, AzureFunctionsAppContainderV1, AzureFunctionAppV1, AzureFunctionAppV2, AzureFunctionOnKubernetesV1, AzureKeyVaultV1, AzureKeyVaultV2, AzureMysqlDeploymentV1, AzurePowerhShellV4, AzurePowerhShellV5, AzureResourceGroupDeploymentV2, AzureResourceManagerTemplateDeploymentV3, AzureRmWebAppDeploymentV3, AzureRmWebAppDeploymentV4, AzureSpringCloudV0, AzureVmssDeploymentV0, AzureWebAppContainerV1, AzureWebAppV1, ContainerBuildV0, HelmDeployV0, HelmDeployV1, JenkinsDownloadArtifactsV1, KubeloginInstallerV0, KubernetesManifestV1, KubernetesV1, PackerBuildV0, PackerBuildV1

Description: Fixed a bug with MSAL library for Node 10 runner (when AGENT_USENODE10 knob is used)

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) Y AB#2194313

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

# Conflicts:
#	Tasks/AzureFunctionAppContainerV1/_buildConfigs/Node20/package-lock.json
#	Tasks/AzureFunctionAppContainerV1/_buildConfigs/Node20/package.json
#	Tasks/AzureFunctionAppV1/_buildConfigs/Node20/package-lock.json
#	Tasks/AzureFunctionAppV1/_buildConfigs/Node20/package.json
#	Tasks/AzureFunctionAppV2/_buildConfigs/Node20/package-lock.json
#	Tasks/AzureFunctionAppV2/_buildConfigs/Node20/package.json
#	Tasks/AzureMysqlDeploymentV1/_buildConfigs/Node20/package-lock.json
#	Tasks/AzureMysqlDeploymentV1/_buildConfigs/Node20/package.json
#	Tasks/AzureSpringCloudV0/_buildConfigs/Node20/package-lock.json
#	Tasks/AzureSpringCloudV0/_buildConfigs/Node20/package.json
#	Tasks/AzureSpringCloudV0/task.json
#	_generated/AzureFunctionAppContainerV1_Node20/package-lock.json
#	_generated/AzureFunctionAppContainerV1_Node20/package.json
#	_generated/AzureFunctionAppV1_Node20/package-lock.json
#	_generated/AzureFunctionAppV1_Node20/package.json
#	_generated/AzureFunctionAppV2_Node20/package-lock.json
#	_generated/AzureFunctionAppV2_Node20/package.json
#	_generated/AzureMysqlDeploymentV1_Node20/package-lock.json
#	_generated/AzureMysqlDeploymentV1_Node20/package.json
#	_generated/AzureSpringCloudV0_Node20/package-lock.json
#	_generated/AzureSpringCloudV0_Node20/package.json
Copy link

azure-boards bot commented Jul 9, 2024

✅ Successfully linked to Azure Boards work item(s):

@DenisNikulin5 DenisNikulin5 changed the title Users/v denikulin/fix msal for node 10 Fixed a bug with MSAL library for Node 10 runner Jul 9, 2024
@DenisNikulin5 DenisNikulin5 changed the title Fixed a bug with MSAL library for Node 10 runner Fix a bug with MSAL library for Node 10 runner Jul 9, 2024
@DenisNikulin5 DenisNikulin5 marked this pull request as ready for review July 9, 2024 10:55
# Conflicts:
#	Tasks/AzureRmWebAppDeploymentV3/_buildConfigs/Node20/package-lock.json
#	Tasks/AzureRmWebAppDeploymentV3/_buildConfigs/Node20/package.json
#	Tasks/AzureRmWebAppDeploymentV4/_buildConfigs/Node20/package-lock.json
#	Tasks/AzureRmWebAppDeploymentV4/_buildConfigs/Node20/package.json
#	Tasks/AzureWebAppContainerV1/_buildConfigs/Node20/package-lock.json
#	Tasks/AzureWebAppContainerV1/_buildConfigs/Node20/package.json
#	Tasks/AzureWebAppV1/_buildConfigs/Node20/package-lock.json
#	_generated/AzureRmWebAppDeploymentV3_Node20/package-lock.json
#	_generated/AzureRmWebAppDeploymentV3_Node20/package.json
#	_generated/AzureRmWebAppDeploymentV4_Node20/package-lock.json
#	_generated/AzureRmWebAppDeploymentV4_Node20/package.json
#	_generated/AzureWebAppContainerV1_Node20/package-lock.json
#	_generated/AzureWebAppContainerV1_Node20/package.json
#	_generated/AzureWebAppV1_Node20/package-lock.json
@DenisNikulin5 DenisNikulin5 enabled auto-merge (squash) July 11, 2024 07:30
@DenisNikulin5 DenisNikulin5 disabled auto-merge July 11, 2024 08:44
@DmitriiBobreshev
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@DmitriiBobreshev
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@DmitriiBobreshev
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@DmitriiBobreshev DmitriiBobreshev enabled auto-merge (squash) July 16, 2024 09:59
@DmitriiBobreshev DmitriiBobreshev merged commit 28dad89 into master Jul 16, 2024
11 checks passed
@DmitriiBobreshev DmitriiBobreshev deleted the users/v-denikulin/fix-msal-for-node-10 branch July 16, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants