-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug with MSAL library for Node 10 runner #20131
Merged
DmitriiBobreshev
merged 25 commits into
master
from
users/v-denikulin/fix-msal-for-node-10
Jul 16, 2024
Merged
Fix a bug with MSAL library for Node 10 runner #20131
DmitriiBobreshev
merged 25 commits into
master
from
users/v-denikulin/fix-msal-for-node-10
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Tasks/AzureFunctionAppContainerV1/_buildConfigs/Node20/package-lock.json # Tasks/AzureFunctionAppContainerV1/_buildConfigs/Node20/package.json # Tasks/AzureFunctionAppV1/_buildConfigs/Node20/package-lock.json # Tasks/AzureFunctionAppV1/_buildConfigs/Node20/package.json # Tasks/AzureFunctionAppV2/_buildConfigs/Node20/package-lock.json # Tasks/AzureFunctionAppV2/_buildConfigs/Node20/package.json # Tasks/AzureMysqlDeploymentV1/_buildConfigs/Node20/package-lock.json # Tasks/AzureMysqlDeploymentV1/_buildConfigs/Node20/package.json # Tasks/AzureSpringCloudV0/_buildConfigs/Node20/package-lock.json # Tasks/AzureSpringCloudV0/_buildConfigs/Node20/package.json # Tasks/AzureSpringCloudV0/task.json # _generated/AzureFunctionAppContainerV1_Node20/package-lock.json # _generated/AzureFunctionAppContainerV1_Node20/package.json # _generated/AzureFunctionAppV1_Node20/package-lock.json # _generated/AzureFunctionAppV1_Node20/package.json # _generated/AzureFunctionAppV2_Node20/package-lock.json # _generated/AzureFunctionAppV2_Node20/package.json # _generated/AzureMysqlDeploymentV1_Node20/package-lock.json # _generated/AzureMysqlDeploymentV1_Node20/package.json # _generated/AzureSpringCloudV0_Node20/package-lock.json # _generated/AzureSpringCloudV0_Node20/package.json
✅ Successfully linked to Azure Boards work item(s): |
DenisNikulin5
changed the title
Users/v denikulin/fix msal for node 10
Fixed a bug with MSAL library for Node 10 runner
Jul 9, 2024
DenisNikulin5
changed the title
Fixed a bug with MSAL library for Node 10 runner
Fix a bug with MSAL library for Node 10 runner
Jul 9, 2024
DenisNikulin5
requested review from
manolerazvan,
a team,
YevheniiKholodkov,
jvano,
dannysongg,
FinVamp1 and
patelchandni
as code owners
July 9, 2024 10:55
# Conflicts: # Tasks/AzureRmWebAppDeploymentV3/_buildConfigs/Node20/package-lock.json # Tasks/AzureRmWebAppDeploymentV3/_buildConfigs/Node20/package.json # Tasks/AzureRmWebAppDeploymentV4/_buildConfigs/Node20/package-lock.json # Tasks/AzureRmWebAppDeploymentV4/_buildConfigs/Node20/package.json # Tasks/AzureWebAppContainerV1/_buildConfigs/Node20/package-lock.json # Tasks/AzureWebAppContainerV1/_buildConfigs/Node20/package.json # Tasks/AzureWebAppV1/_buildConfigs/Node20/package-lock.json # _generated/AzureRmWebAppDeploymentV3_Node20/package-lock.json # _generated/AzureRmWebAppDeploymentV3_Node20/package.json # _generated/AzureRmWebAppDeploymentV4_Node20/package-lock.json # _generated/AzureRmWebAppDeploymentV4_Node20/package.json # _generated/AzureWebAppContainerV1_Node20/package-lock.json # _generated/AzureWebAppContainerV1_Node20/package.json # _generated/AzureWebAppV1_Node20/package-lock.json
starkmsu
approved these changes
Jul 9, 2024
This reverts commit d8a098f.
kirill-ivlev
approved these changes
Jul 10, 2024
vmapetr
approved these changes
Jul 10, 2024
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureAppServiceManageV0, AzureAppServiceSettingsV1, AzureFileCopyV2, AzureFileCopyV3, AzureFileCopyV5, AzureFileCopyV6, AzureFunctionsAppContainderV1, AzureFunctionAppV1, AzureFunctionAppV2, AzureFunctionOnKubernetesV1, AzureKeyVaultV1, AzureKeyVaultV2, AzureMysqlDeploymentV1, AzurePowerhShellV4, AzurePowerhShellV5, AzureResourceGroupDeploymentV2, AzureResourceManagerTemplateDeploymentV3, AzureRmWebAppDeploymentV3, AzureRmWebAppDeploymentV4, AzureSpringCloudV0, AzureVmssDeploymentV0, AzureWebAppContainerV1, AzureWebAppV1, ContainerBuildV0, HelmDeployV0, HelmDeployV1, JenkinsDownloadArtifactsV1, KubeloginInstallerV0, KubernetesManifestV1, KubernetesV1, PackerBuildV0, PackerBuildV1
Description: Fixed a bug with MSAL library for Node 10 runner (when AGENT_USENODE10 knob is used)
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Y AB#2194313
Checklist: