Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vstest zip uploads with Prod storage account #19921

Merged
merged 9 commits into from
May 29, 2024

Conversation

vinayakmsft
Copy link
Contributor

@vinayakmsft vinayakmsft commented May 29, 2024

Task name: VstestV2

Description: In this PR, we are just changing the zip file upload link for the VstestV2 task. Earlier we were using the non-prod subscription and storage account for uploading the zip file. But now we have created a new service connection called TcmProdWcus0 and created a new storage account under the AME subscription - TM-PROD-WCUS0. Following are the build and the release pipelines with updated storage account details .

Build pipeline - https://dev.azure.com/mseng/AzureDevOps/_build/results?buildId=28213918&view=results

Release pipeline - https://dev.azure.com/mseng/AzureDevOps/_releaseProgress?releaseId=20962195&_a=release-environment-logs&environmentId=211455629

You can test the new zip file using this link - https://testmanagementstore.blob.core.windows.net/testmanagementcontainer/28213918/TestAgent.zip

Local testing screenshots For Vstest

image
image

Documentation changes required: (Y/N) No. This is not a functionality change.

Added unit tests: (Y/N) NA.

Attached related issue: (Y/N) This is a security issue

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Copy link
Contributor

@eswarnathp eswarnathp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@eswarnathp eswarnathp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dogirala dogirala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a query - is this file expected to be merged?, it is not generated, same query for tests folder

Tasks/PublishTestResultsV2/_buildConfigs/Node20/Tests/package-lock.json

@vinayakmsft vinayakmsft enabled auto-merge (squash) May 29, 2024 12:13
@vinayakmsft vinayakmsft merged commit 652a8ee into master May 29, 2024
11 checks passed
@quasarea quasarea mentioned this pull request May 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants