-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vstest zip uploads with Prod storage account #19921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a query - is this file expected to be merged?, it is not generated, same query for tests folder
Tasks/PublishTestResultsV2/_buildConfigs/Node20/Tests/package-lock.json
Task name: VstestV2
Description: In this PR, we are just changing the zip file upload link for the VstestV2 task. Earlier we were using the non-prod subscription and storage account for uploading the zip file. But now we have created a new service connection called TcmProdWcus0 and created a new storage account under the AME subscription - TM-PROD-WCUS0. Following are the build and the release pipelines with updated storage account details .
Build pipeline - https://dev.azure.com/mseng/AzureDevOps/_build/results?buildId=28213918&view=results
Release pipeline - https://dev.azure.com/mseng/AzureDevOps/_releaseProgress?releaseId=20962195&_a=release-environment-logs&environmentId=211455629
You can test the new zip file using this link - https://testmanagementstore.blob.core.windows.net/testmanagementcontainer/28213918/TestAgent.zip
Local testing screenshots For Vstest
Documentation changes required: (Y/N) No. This is not a functionality change.
Added unit tests: (Y/N) NA.
Attached related issue: (Y/N) This is a security issue
Checklist: