-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug with escaped quotes in toolrunner _argStringToArray #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatolybolshakov
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
EzzhevNikita
approved these changes
Jun 28, 2021
alexander-smolyakov
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT and please take a look at the comment
anatolybolshakov
pushed a commit
that referenced
this pull request
Jun 30, 2021
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
…t#771) * fix escaped quotes in toolrunner * add unit test for escaped quotes * fix output * fix console * format code Co-authored-by: Anna Opareva <v-aopareva@microsoft.com>
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
* fix escaped quotes in toolrunner * add unit test for escaped quotes * fix output * fix console * format code * new patch version Co-authored-by: Anna Opareva <v-aopareva@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug with escaped quotes in toolrunner _argStringToArray
for issue #648
If we try passing quotes as a value even that is being eaten up by task-lib
Input:
-- TestRunParameters.Parameter(name=paramName,value=argwith"aquote)
Output
-- TestRunParameters.Parameter(name=paramName,value=argwithaquote)
If we use backslash then the quote doesn't is eaten up.
Input:
-- TestRunParameters.Parameter(name=paramName,value=argwith\"aquote)
Output
-- TestRunParameters.Parameter(name=paramName,value=argwith"aquote)
If we use backslash then the quote doesn't is eaten up.
Input:
-- TestRunParameters.Parameter(name=\"EdiStagingFunctionsKey\",value=\"key2\")
Output:
TestRunParameters.Parameter(name="EdiStagingFunctionsKey",value="key2")