Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with escaped quotes in toolrunner _argStringToArray #771

Merged
merged 5 commits into from
Jun 29, 2021

Conversation

AnnaOpareva
Copy link
Contributor

fix bug with escaped quotes in toolrunner _argStringToArray

for issue #648

  1. If we try passing quotes as a value even that is being eaten up by task-lib
    Input: -- TestRunParameters.Parameter(name=paramName,value=argwith"aquote)
    Output -- TestRunParameters.Parameter(name=paramName,value=argwithaquote)

  2. If we use backslash then the quote doesn't is eaten up.
    Input: -- TestRunParameters.Parameter(name=paramName,value=argwith\"aquote)
    Output -- TestRunParameters.Parameter(name=paramName,value=argwith"aquote)

  3. If we use backslash then the quote doesn't is eaten up.
    Input: -- TestRunParameters.Parameter(name=\"EdiStagingFunctionsKey\",value=\"key2\")
    Output: TestRunParameters.Parameter(name="EdiStagingFunctionsKey",value="key2")

@AnnaOpareva AnnaOpareva requested a review from a team June 25, 2021 12:06
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@anatolybolshakov anatolybolshakov requested a review from a team June 25, 2021 14:42
@EzzhevNikita EzzhevNikita requested a review from a team June 28, 2021 11:55
Copy link

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT and please take a look at the comment

node/toolrunner.ts Outdated Show resolved Hide resolved
@AnnaOpareva AnnaOpareva merged commit 68bae9a into master Jun 29, 2021
anatolybolshakov pushed a commit that referenced this pull request Jun 30, 2021
* fix escaped quotes in toolrunner

* add unit test for escaped quotes

* fix output

* fix console

* format code

* new patch version

Co-authored-by: Anna Opareva <v-aopareva@microsoft.com>
fullstackinfo pushed a commit to fullstackinfo/azure-pipelines-task-lib that referenced this pull request Aug 17, 2024
…t#771)

* fix escaped quotes in toolrunner

* add unit test for escaped quotes

* fix output

* fix console

* format code

Co-authored-by: Anna Opareva <v-aopareva@microsoft.com>
fullstackinfo pushed a commit to fullstackinfo/azure-pipelines-task-lib that referenced this pull request Aug 17, 2024
* fix escaped quotes in toolrunner

* add unit test for escaped quotes

* fix output

* fix console

* format code

* new patch version

Co-authored-by: Anna Opareva <v-aopareva@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants