Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cross platform session token cache global locking #470

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Enable cross platform session token cache global locking #470

merged 1 commit into from
Feb 7, 2024

Conversation

embetten
Copy link
Contributor

@embetten embetten commented Feb 6, 2024

Bug fix #416

  • Move session token cache file lock to single wait handle.
  • Add new session cache specific cancel message so the cancel message is not printed twice.
  • Pass cancellation token to credential request handler.

@embetten embetten marked this pull request as ready for review February 7, 2024 18:24
cormacpayne
cormacpayne approved these changes Feb 7, 2024
View reviewed changes
Copy link

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@embetten embetten merged commit 3bdd257 into master Feb 7, 2024
2 checks passed
@embetten embetten deleted the embetten/cache-lock branch February 7, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmyersmsft jmyersmsft jmyersmsft approved these changes

@cormacpayne cormacpayne cormacpayne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session token cache global lock doesn't work cross-platform
3 participants
@embetten @cormacpayne @jmyersmsft