Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Removed mrt.gdnsuppress and the reference to it #4952

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

alexlamtest
Copy link
Contributor

We are now using the analyzeTargetGlob mechanism to skip BinSkim scanning of the Packages folder, so we no longer need the finer grain suppressions in mrt.gdnsuppress.
Hence, deleting mrt.gdnsuppress and removing the reference to it in the WindowsAppSDK-Build-Stage.yml file.

How verified:

  • A private pipeline run with the changes in this PR has succeeded in the Build Stage.

///////////

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

@alexlamtest
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alexlamtest alexlamtest enabled auto-merge (squash) December 10, 2024 20:02
@alexlamtest alexlamtest merged commit d99c353 into main Dec 10, 2024
26 checks passed
@alexlamtest alexlamtest deleted the user/alexlam/RemoveSuppression-main-20241210 branch December 10, 2024 21:41
godlytalias pushed a commit that referenced this pull request Dec 13, 2024
* Update WindowsAppSDK-Build-Stage.yml

* Delete dev/MRTCore/.gdn/mrt.gdnsuppress
codendone pushed a commit that referenced this pull request Jan 10, 2025
* Update WindowsAppSDK-Build-Stage.yml

* Delete dev/MRTCore/.gdn/mrt.gdnsuppress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants