Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version info to WindowsAppRuntimeInstall.exe #3884

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Add version info to WindowsAppRuntimeInstall.exe #3884

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27233c1
Add version info to WindowsAppRuntimeInstall.exe
codendone Sep 27, 2023
b97c5f7
Remove unnecessary lines.
codendone Sep 27, 2023
8cd3e2a
Additional changes to bring in the version.
codendone Oct 2, 2023
2a3e60e
Add copyright in the placeholder file.
codendone Oct 2, 2023
681dd1a
Merge branch 'develop' into user/codendone/installerVersion
codendone Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions installer/dev/WindowsAppRuntimeInstall.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,8 @@ END
/////////////////////////////////////////////////////////////////////////////
#endif // not APSTUDIO_INVOKED

#include <WindowsAppSDK-VersionInfo.h>

#define VERSIONINFO_FILENAME "WindowsAppRuntimeInstall.exe"
#define VERSIONINFO_FILETYPE VFT_APP
#include "eng\common\VersionInfo\AssemblyInfo.ver"
1 change: 1 addition & 0 deletions installer/dev/WindowsAppRuntimeInstall.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@
<ItemGroup>
<ResourceCompile Include="WindowsAppRuntimeInstall.rc">
<PreprocessorDefinitions Condition="Exists('windowsappruntime_definitions_override.h')">USE_DEFINITIONS_OVERRIDE_HEADER;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(RepoRoot);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
</ResourceCompile>
</ItemGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
Expand Down
4 changes: 4 additions & 0 deletions installer/dev/WindowsAppSDK-VersionInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// This file is a PLACEHOLDER which will be replaced in the CreateInstaller
// build pipeline with a file which defines WINDOWSAPPSDK_RELEASE_MAJOR
// and WINDOWSAPPSDK_RELEASE_MINOR. For the dev inner loop, these will remain
// undefined and just version the installer as 0.0.