Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto initializer sources without a target, and define a user-available property to add WindowsAppSDK-VersionInfo.cs exactly once #3860

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

Scottj1s
Copy link
Member

@Scottj1s Scottj1s commented Sep 18, 2023

Cherry-pick for 1.4.2 servicing. This fix enables removal of this workaround.

…er-available property to add WindowsAppSDK-VersionInfo.cs exactly once (#3819)

* Use CoreCompileDependsOn to ensure that version info is added before XamlPreCompile, not just CoreCompile

* restructured to enable apps to easily include WindowsAppSDK-VersionInfo.cs exactly once for all compilations (Xaml, etc)

* removed cruft target
@Scottj1s
Copy link
Member Author

/cc @bpulliam

@Scottj1s Scottj1s requested a review from bpulliam September 19, 2023 17:04
@Scottj1s
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@Scottj1s
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Stop running tests on 21h1 OS image because this version has reached end of support, and the image is no longer in the test VM pool.
@Scottj1s
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@Scottj1s Scottj1s enabled auto-merge (squash) September 20, 2023 18:52
@Scottj1s Scottj1s merged commit ff77278 into release/1.4-stable Sep 20, 2023
@Scottj1s Scottj1s deleted the user/sjones/versioninfo_cp branch September 20, 2023 19:14
Copy link
Contributor

@alexlamtest alexlamtest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the 21h1 removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants