KozaniManager in-proc WinRT APIs and OOP classic COM APIs to activate remote apps #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remote apps. Created KozaniManager in-proc WinRT APIs and OOP classic COM APIs to activate remote apps. Added tests to validate the changes.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@DrusTheAxe , @wcheng-msft , @cwruss , @sachintaMSFT - I have the PR open for review. Please take a look. Thanks! |
|
@rhuang-msft - test PR comment communication. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
DrusTheAxe
requested changes
Jan 31, 2023
test/Kozani/KozaniManagerRuntimeTests/KozaniManagerRuntimeTests.cpp
Outdated
Show resolved
Hide resolved
test/Kozani/KozaniManagerRuntimeTests/KozaniManagerRuntimeTests.cpp
Outdated
Show resolved
Hide resolved
test/Kozani/KozaniManagerRuntimeTests/KozaniManagerRuntimeTests.cpp
Outdated
Show resolved
Hide resolved
test/Kozani/KozaniManagerRuntimeTests/KozaniManagerRuntimeTests.cpp
Outdated
Show resolved
Hide resolved
wcheng-msft
reviewed
Feb 1, 2023
test/Kozani/KozaniManagerRuntimeTests/KozaniManagerRuntimeTests.cpp
Outdated
Show resolved
Hide resolved
wcheng-msft
reviewed
Feb 1, 2023
…com/microsoft/WindowsAppSDK into user/rhuang-msft/KozaniManagerWinRT
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
DrusTheAxe
reviewed
Feb 2, 2023
| @@ -9,6 +9,16 @@ | |||
|
|
|||
| namespace winrt::Microsoft::Kozani::ManagerRuntime::implementation | |||
| { | |||
| ManagerRuntimeManager::ManagerRuntimeManager() | |||
| { | |||
| m_kozaniManager = wil::CoCreateInstance<KozaniManager, IKozaniManager>(CLSCTX_LOCAL_SERVER); | |||
There was a problem hiding this comment.
Seems a bit odd to do in the ctor but the ctor's private, right? Only way to get here is via the static Create()?
There was a problem hiding this comment.
we cannot put ctor in private as it will cause cpp/winrt build error. I tried and it failed. It is the same pattern as all the other APIs in this solution. None of them have private ctor.
DrusTheAxe
approved these changes
Feb 2, 2023
| { | ||
| #pragma region IKozaniStausCallback_methods | ||
| #pragma region IKozaniStatusCallback_methods |
There was a problem hiding this comment.
Does the region name need to be 1 word?
(been a while since I used this pragma)
There was a problem hiding this comment.
it can have space.
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created KozaniManager in-proc WinRT APIs and OOP classic COM APIs to activate remote apps. Added tests and test package to validate the changes.