Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DynamicDependencies\Test_Win* dependencies to prevent out-of-order builds #3195

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

DrusTheAxe
Copy link
Member

Also remove UTF8 BOM from DevCheck.cmd (unnecessary and causes errors in some command processors)

@DrusTheAxe DrusTheAxe added bug Something isn't working area-DynamicDependencies labels Nov 30, 2022
@DrusTheAxe DrusTheAxe added this to the 1.3 milestone Nov 30, 2022
@DrusTheAxe DrusTheAxe self-assigned this Nov 30, 2022
@ghost ghost added the needs-triage 🔍 label Nov 30, 2022
@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@DrusTheAxe DrusTheAxe enabled auto-merge (squash) November 30, 2022 01:59
@DrusTheAxe
Copy link
Member Author

That's a weird pipeline failure. Infra issue (not the code itself). Let's try again...

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@DrusTheAxe DrusTheAxe merged commit 86967c9 into develop Nov 30, 2022
@DrusTheAxe DrusTheAxe deleted the user/drustheaxe/dyndep-test-dependencies-widgets branch November 30, 2022 22:09
kythant pushed a commit that referenced this pull request Dec 16, 2022
…rder builds (#3195)

* Remove UTF8 BOM

* Fix test\DynamicDependency\Test_Win* to include a dependency on Framework.Widgets so the build ensures proper build order
kythant added a commit that referenced this pull request Dec 16, 2022
* Update dependencies from https://dev.azure.com/microsoft/ProjectReunion/_git/ProjectReunionInternal build Maestro-UpdateEngCommon_2212.09001 (#3240)

Microsoft.WinAppSDK.EngCommon
 From Version 1.2.220923.2 -> To Version 1.3.221209100

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Various BuildTransportPackage.ps1 Refactors and Fixes (#3221)

* Update DynamicDependencies\Test_Win* dependencies to prevent out-of-order builds (#3195)

* Remove UTF8 BOM

* Fix test\DynamicDependency\Test_Win* to include a dependency on Framework.Widgets so the build ensures proper build order

Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Howard Kapustein <howardk@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DynamicDependencies bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants