Fix dependencies and bad merge #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trapDLL but didn't declare project depednencies so build-out-of-order and 'can't find MddBootstrap.h' errors :-( Fixed
…to the latest one for consistency. Ditto for C++/WinRT.
…pendency on WindowsAppRuntime_DLL so they could be built before dev\Deployment\*.idl was compiled and thus can't find the DeploymentInitializeOptions type; added missing dependency to ensure build order
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
kythant
approved these changes
Nov 22, 2022
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 versions of WIL were referenced across the projects. Updated to consistently reference the newer one.
2 versions of C++/WinRT were referenced across the projects. Updated to consistently reference the newer one.
Removed test\ToastNotificationsTests project remnant (no such project there anymore; leftover from bad merge?)
LRPTests was a VS2019 project (PlatformToolset=v142); updated to VS2022 (=v143)
LRPTests and Test_DeploymentManagerAutoInitialize\CPP* projects didn't fully declare build order dependencies so on a fast enough machine and Rebuild All you could get out-of-order build and thus build errors; fixed.