Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LRP tests for notifications #2900

Merged
merged 9 commits into from
Sep 12, 2022
Merged

Refactor LRP tests for notifications #2900

merged 9 commits into from
Sep 12, 2022

Conversation

pmpurifoy
Copy link
Contributor

@pmpurifoy pmpurifoy commented Aug 23, 2022 •
edited
Loading

  • Restructured test locations for Notification tests
  • Added LRP test dll covering all exposed functions

@ghost ghost added the needs-triage label Aug 23, 2022
@loneursid loneursid added the area-Notifications Toast notification, badges, Live Tiles, push notifications label Aug 26, 2022
danielayala94
danielayala94 reviewed Aug 30, 2022
View reviewed changes
test/LRPTests/APITests.cpp
BEGIN_TEST_CLASS(LRPTests)
TEST_CLASS_PROPERTY(L"Description", L"Windows App SDK Push Notifications Long Running Process tests")
TEST_CLASS_PROPERTY(L"ThreadingModel", L"MTA")
TEST_CLASS_PROPERTY(L"RunAs:Class", L"RestrictedUser")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? Sounds like this is a non-admin user? Then how is it different from not specifying this property at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RestrictedUser means that the process is running as a user at medium-IL. This is our only supported scenario, but in the future we will need to add ElevatedUser to make sure elevated processes can call into the LRP.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the default IL we get for the tests if we don't specify a user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't specify a user, TAEF will run in the context of which TAEF is running.

sharath2727
sharath2727 reviewed Sep 8, 2022
View reviewed changes
@pmpurifoy
Copy link
Contributor Author

/azp run TransportPackage-Foundation-PR

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@pmpurifoy
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

sharath2727
sharath2727 reviewed Sep 12, 2022
View reviewed changes
@pmpurifoy
Copy link
Contributor Author

/azp run TransportPackage-Foundation-PR

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@pmpurifoy
Copy link
Contributor Author

/azp run TransportPackage-Foundation-PR

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@pmpurifoy pmpurifoy merged commit 467d9cb into develop Sep 12, 2022
@pmpurifoy pmpurifoy deleted the user/purifoypaul/RefactorLRPTests branch September 12, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielayala94 danielayala94 danielayala94 left review comments

@loneursid loneursid loneursid left review comments

@sharath2727 sharath2727 sharath2727 approved these changes

@hulumane hulumane Awaiting requested review from hulumane

Assignees
No one assigned
Labels
area-Notifications Toast notification, badges, Live Tiles, push notifications needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmpurifoy @sharath2727 @danielayala94 @loneursid