-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeploymentManager auto-initializer #2835
Conversation
…nspired by Bootstrapper's auto-initializer. Split test\Deployment into subdirs. Working through build-isms
…ve path notation for package reference goo...
/azp run |
Pull request contains merge conflicts. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Pull request contains merge conflicts. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…icrosoft/WindowsAppSDK into user/drustheaxe/depmgrautoinit
…ifyCopyrightHeaders script is demanding]
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
const AppModel::Identity::PackageIdentity& packageIdentity, | ||
const std::wstring& release); | ||
} | ||
|
||
inline void Initialize_StopSuccessActivity( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these parameter changes, the inline function should be named StopActivity instead of StopSuccessActivity.
THROW_HR(hr); | ||
} | ||
|
||
// Success! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you are not logging success activity here for telemetry.
Add an auto-initializer for DeploymentManager (very similar to the Bootstrapper's auto-initializer).
If DeploymentManager Initialize fails...
...Write to the eventlog
...Optionally
The optional behavior is triggered by new
DeploymentInitializeOptions
properties or by environment variablesTesting partial but incomplete as I need a real build (franken-hacking has been too messy to finish E2E testing). The DeploymentManager auto-initializer is inert/unused unless WindowsAppSdkDeploymentManagerInitialize=true and the default to enable that is commented out for now, making this PR functional but inert so I can get a build turned with real packages for further testing.
*.targets updated to provide build-time control.
WindowsAppSDKDeploymentManagerAutoInitialize
=false
DeploymentInitializeOptions
toDeploymentManager.Initialize()
For example, to disable the auto-initializer add to your *proj file:
or to enable the auto-initializer (default) but use the DebugBreak+FailFast options (instead of the default)
https://task.ms/40724739