Publish New AppNotificationBuilder API #2834
Conversation
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
...oft.Windows.AppNotifications.Projection/Microsoft.Windows.AppNotifications.Projection.csproj
Outdated
Show resolved
Hide resolved
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
…osoft/WindowsAppSDK into user/erlangl/PublishBuilder
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
...otifications.Builder.Projection/Microsoft.Windows.AppNotifications.Builder.Projection.csproj
Show resolved
Hide resolved
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
|
We should talk about how to test this e2e - is there a test app in the repo that would have consumed this correctly via the nuspec? There needs to be one in the Samples repo that shows a great use, so we'd have that as a cross-check. |
I've used the nuget (downloaded from the output of the build pipeline) and samples to test and verify this and I can confirm that the sample builds with the new APIs. The issue is that the pipelines only produce a nuget, no installer or the 4 MSIX needed, so it can't run. The nightly build produces everything, but I'd need to merge this first in order to get the binaries. |
@jonwis - I was wrong about the testing stuff. Thanks to @kythant for setting me up straight. I've been able to test the feature e2e using our samples. The msix were produced by the pipelines. I was just not looking at the right place. |
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\Microsoft.Windows.AppNotifications.Projection\Microsoft.Windows.AppNotifications.Projection.csproj" /> |
There was a problem hiding this comment.
I misunderstood from the email thread. So you have the project reference, but it only picks up the projection assembly and not the metadata? Odd. We can debug with a binlog at some point, but the Reference below is fine for now.
There was a problem hiding this comment.
What I was trying to say is that after adding the dependency on the project, I was expecting that this wouldn't be necessary:
<Reference Include="Microsoft.Windows.AppNotifications">
<HintPath>$(OutDir)..\WindowsAppRuntime_DLL\StrippedWinMD\Microsoft.Windows.AppNotifications.winmd</HintPath>
<IsWinMDFile>true</IsWinMDFile>
</Reference>
but it turns out it is still needed. (VS should be able to infer this information from the reference project)
|
e2e test -- that's what PRojectReunionInternal's \test<https://dev.azure.com/microsoft/projectreunion/_git/ProjectReunionInternal?path=/test> dirtree is for: IntegratedTests. All features should have coverage.
The issue is that the pipelines only produce a nuget, no installer or the 4 MSIX needed, so it can't run.
Which pipelines<https://dev.azure.com/Microsoft/projectreunion/_build>?
If you have the nuget you don't need the installer. The nuget contains all the MSIX
[cid:2ade13d9-5467-49ee-9244-7da371601b8d]
Unzip that and install them e.g.
powershell -c add-appxpackage -ForceTargetApplicationShutdown %TEMP%\wherever-the-nupkg-lives\tools\MSIX\win10-x64\*.msix
- Howard
…________________________________
From: eric langlois ***@***.***>
Sent: Tuesday, August 9, 2022 10:04 AM
To: microsoft/WindowsAppSDK ***@***.***>
Cc: Howard Kapustein ***@***.***>; Review requested ***@***.***>
Subject: Re: [microsoft/WindowsAppSDK] Publish New AppNotificationBuilder API (PR #2834)
We should talk about how to test this e2e - is there a test app in the repo that would have consumed this correctly via the nuspec?
There needs to be one in the Samples repo that shows a great use, so we'd have that as a cross-check.
I've used the samples to test and verify this and I can confirm that the sample builds with the new APIs. The issue is that the pipelines only produce a nuget, no installer or the 4 MSIX needed, so it can't run. The nightly build produces everything, but I'd need to merge this first in order to get the binaries.
—
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FWindowsAppSDK%2Fpull%2F2834%23issuecomment-1209640567&data=05%7C01%7CHoward.Kapustein%40microsoft.com%7C83d5619f3f4440f6c61908da7a2930b4%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C637956614578177196%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EigFsk98tdwZr36vt6ASRxkD3yuyLVmajrG%2BS9z5N6s%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAARUHX6LIR3PUWF7N47MKTVYKFQ7ANCNFSM556XZ7FA&data=05%7C01%7CHoward.Kapustein%40microsoft.com%7C83d5619f3f4440f6c61908da7a2930b4%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C637956614578177196%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gwAPjynRygQuqKpNLvH6NjhRXw%2BYFhtspHqxdPOs1nc%3D&reserved=0>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
I've tested by downloading the nuget, installing it in two of our samples (one C++, one C#) and using the new APIs. I can confirm that the new APIs can be used in the samples and the samples build and run as expected.