Cherry-pick fix for break away process creation attribute from release/1.1-stable to main #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-normalized error codes.
* Create Breakaway process for DeplomentAgent.exe in Running state (not in suspended state) * And remove Resume * Don't inherent parent handles in breakaway process * Create process outside desktop app runtime environment instead * Don't return a copy but a reference to tracelogger activity class object Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DrusTheAxe
approved these changes
Jun 8, 2022
| @@ -54,6 +55,12 @@ namespace WindowsAppRuntimeInstaller::InstallActivity | |||
| return m_currentResourceId; | |||
| } | |||
|
|
|||
| const HRESULT& GetdeploymentErrorHresult() const | |||
There was a problem hiding this comment.
BTW typo -- should be capital 'D'eployment
Please fix in a future PR
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking 30a8d11 from release/1.1-stable to main.