Add missing '>' to Microsoft.WindowsAppSDK.Bootstrap.CS.targets

[kythant]

Add missing '>' to Microsoft.WindowsAppSDK.Bootstrap.CS.targets.

Added smoke test to check if props and targets are formed properly.

[kythant]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jonwis]

How do we get test coverage for this kind of thing in the future?

[riverar]

Shouldn't this entire line be deleted? There's no matching end tag... and an empty DefineConstants doesn't really make sense.

[kythant]

Good question. Taking a closer look, seems like we don't even need this line.

[kythant]

@DrusTheAxe Want to double check with you to see if we can remove it.

[DrusTheAxe]

Correct -- delete line 4. That's a typo

For valid sample syntax see https://stackoverflow.com/questions/36793499/defineconstants-in-addition-to-existing-ones-in-csproj#36793713

[kythant]

@jonwis
I caught this error because the nightly Foundation build which is internal ran into this error in it's IntegrationTest stage which builds a WindowsAppSDK Nuget, builds the WindowsAppSDK tests from the internal repo, and run against it. However this isn't run as part of a PR validation because this stage needs access to the internal feed due the dependencies on other transport packages which are internal. External contributors wouldn't be able to see this type of validation.

To catch this during the pull request validation/checks, we would need to build a test app that makes use of this target that will directly make use of the Foundation transport package.

[riverar]

To catch this during the pull request validation/checks, we would need to build a test app that makes use of this target that will directly make use of the Foundation transport package.

Maybe in the short term, PR validation could run with something like this to verify the XML is at least well formed.

- name: smoke test targets
  shell: pwsh
  run: |
     Get-ChildItem *.targets | ForEach-Object { $_.Name; [xml](Get-Content $_) | Out-Null }

[DrusTheAxe]

LGTM if you delete line 4

Rafael's verify-XML-is-WellFormed is a good (and cheap :-) suggestion. Should be applied to all XML files under /build/NuSpecs

[kythant]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kythant]

https://dev.azure.com/ms/ProjectReunion/_build/results?buildId=299752&view=logs&j=1f3a93c1-6a00-552a-efc0-7a088e8b5e99&t=963d0d2d-e502-590b-95a9-5ef016693b68

Smoke check test for props and targets tested here

[kythant]

https://dev.azure.com/ms/ProjectReunion/_build/results?buildId=299752&view=logs&j=1f3a93c1-6a00-552a-efc0-7a088e8b5e99&t=963d0d2d-e502-590b-95a9-5ef016693b68

Smoke check test for props and targets tested here