Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and update the MRTCore apps #47

Merged
merged 11 commits into from
Aug 13, 2021
Merged

Improve and update the MRTCore apps #47

merged 11 commits into from
Aug 13, 2021
+891 −859

Conversation

rohanp-msft
Copy link
Contributor

@rohanp-msft rohanp-msft commented Jul 15, 2021 •
edited
Loading

This change does the following:

  • For all the samples, set/correct the platform min version to 17763.
  • For the packaged samples, update to NuGet v8.0.1
  • For all the samples, ensure they build and run on x86 and x64 (Debug and Release). For arm64 (Debug and Release), just building is verified as part of this change.
  • For the .NET samples, don't override the .NET 5 targeting packages anymore: the version we get with the latest .NET 5 is newer

Verified
For all these sample apps, I verified that they build and run for x86 and x64, for both Debug and Release. For arm64, I just verified that they build for Debug and Release. Verifying that they run on arm64 will be done separately.

  • WinUI C++ sample app
  • WinUI C# sample app
  • Console unpackaged sample app
  • WinForms unpackaged sample app
  • WPF

@rohanp-msft rohanp-msft self-assigned this Jul 15, 2021
@rohanp-msft rohanp-msft added bug Something isn't working sample request New feature sample request labels Jul 15, 2021
@rohanp-msft rohanp-msft changed the title For the MRTCore apps, set the platform min version, update to NuGet v8.0.1 and ensure they work on x86, x64 and arm64 (Debug and Release) For the MRTCore apps, set/correct the platform min version, update to NuGet v8.0.1 and ensure they work on x86, x64 and arm64 (Debug and Release) Jul 15, 2021
@rohanp-msft rohanp-msft changed the title For the MRTCore apps, set/correct the platform min version, update to NuGet v8.0.1 and ensure they work on x86, x64 and arm64 (Debug and Release) Improve and update the MRTCore apps Jul 15, 2021
@rohanp-msft
Reverted the NuGet package upgrade. Dynamic Dependencies is not prese…
988b01d 
…nt in 8.0 or 8.0.1. Confirmed builds and runs for x86 adn x64, for both Debug and Release. Also, removed Any CPU from the winforms sample.
@rohanp-msft
Add ARM64 support (only build verified so far) in winui apps and winf…
c82c3fd 
…orms app.
@rohanp-msft
Temp commit.
c5d777e
@rohanp-msft
WPF done. Winforms fix.
a12cbd8
@rohanp-msft rohanp-msft marked this pull request as ready for review August 13, 2021 01:13
@angelazhangmsft
Copy link
Contributor

LGTM, the only thing I would suggest is adding a note to the first section of the readme that the unpackaged samples are an experimental feature. Maybe:

Note: The unpackaged sample apps reference an experimental version of the Windows App SDK. Unpackaged app deployment is not currently supported for use by apps in production environments.

@rohanp-msft
Copy link
Contributor Author

LGTM, the only thing I would suggest is adding a note to the first section of the readme that the unpackaged samples are an experimental feature. Maybe:

Note: The unpackaged sample apps reference an experimental version of the Windows App SDK. Unpackaged app deployment is not currently supported for use by apps in production environments.

Done! But I added a link as well. If you think it's better left out, please lmk.

@angelazhangmsft angelazhangmsft self-requested a review August 13, 2021 18:49
@rohanp-msft rohanp-msft merged commit d8d9d23 into main Aug 13, 2021
@rohanp-msft rohanp-msft deleted the user/rohanp/update_mrtcore_apps_to_v_8_0_1 branch August 13, 2021 20:31
beervoley pushed a commit to paulcam206/WindowsAppSDK-Samples that referenced this pull request Dec 8, 2022
@rohanp-msft
Improve and update the MRTCore apps (microsoft#47)
12c279f 
* TF, TPMV, MTPV, MTPMV

* NuGet package updates

* Fixing build config for cs winui release

* Don't override the .NET 5 targeting packages anymore. The version we get with the latest .NET 5 is newer.

* Reverted the NuGet package upgrade. Dynamic Dependencies is not present in 8.0 or 8.0.1. Confirmed builds and runs for x86 adn x64, for both Debug and Release. Also, removed Any CPU from the winforms sample.

* Add ARM64 support (only build verified so far) in winui apps and winforms app.

* Temp commit.

* WPF done. Winforms fix.

* Addressed feedback.

* Forgot to bold the Note part.

* Addressed feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelandrejs axelandrejs axelandrejs approved these changes

@angelazhangmsft angelazhangmsft angelazhangmsft approved these changes

@huichen123 huichen123 Awaiting requested review from huichen123

Assignees

@rohanp-msft rohanp-msft

Labels
bug Something isn't working sample request New feature sample request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohanp-msft @angelazhangmsft @axelandrejs