Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all packaged MRT Core sample apps to v0.8 preview. #40

Merged
merged 3 commits into from
May 29, 2021
Merged

Upgrade all packaged MRT Core sample apps to v0.8 preview. #40

merged 3 commits into from
May 29, 2021

Conversation

rohanp-msft
Copy link
Contributor

@rohanp-msft rohanp-msft commented May 29, 2021 •
edited
Loading

For the WPF app

  1. I removed arm and arm64 configs because arm and arm64 aren't supported:

    • Error: "There was no runtime pack for Microsoft.WindowsDesktop.App.WPF available for the specified RuntimeIdentifier 'win-arm64'."
    • Error: "There was no runtime pack for Microsoft.WindowsDesktop.App.WPF available for the specified RuntimeIdentifier 'win-arm'."

    ARM64 support was added to WPF only in .NET 6 Preview 1: WPF ARM64 Support now available in .NET 6 Preview 1  dotnet/wpf#4117

  2. I removed AnyCPU config because WinUI doesn't support it.

    • Error: "This version of WinUI does not support AnyCPU. Either set Platform or PlatformTarget to one of the following: x86, x64, or arm64."

For the WinUI C# app

  1. I removed AnyCPU config because WinUI doesn't support it.
    • Error: "This version of WinUI does not support AnyCPU. Either set Platform or PlatformTarget to one of the following: x86, x64, or arm64."

How verified
Ran all three apps for x86 and x64

@rohanp-msft rohanp-msft added the sample request New feature sample request label May 29, 2021
@rohanp-msft rohanp-msft self-assigned this May 29, 2021
jefgen
jefgen approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@jefgen jefgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rohanp-msft rohanp-msft merged commit e194b66 into main May 29, 2021
@rohanp-msft rohanp-msft deleted the user/rohanp/upgrade_old_samples_to_point8_preview branch July 13, 2021 22:42
beervoley pushed a commit to paulcam206/WindowsAppSDK-Samples that referenced this pull request Dec 8, 2022
@rohanp-msft
Merge pull request microsoft#40 from microsoft/user/rohanp/upgrade_ol…
a77c511 
…d_samples_to_point8_preview

Upgrade all packaged MRT Core sample apps to v0.8 preview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefgen jefgen jefgen approved these changes

@axelandrejs axelandrejs Awaiting requested review from axelandrejs

@huichen123 huichen123 Awaiting requested review from huichen123

Assignees

@rohanp-msft rohanp-msft

Labels
sample request New feature sample request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanp-msft @jefgen