-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to WASDK 1.4 and related maintenance #1336
Conversation
…fore XamlPreCompile, to remove dupe
See also: |
Note: build failing because in Microsoft.WindowsAppSDK.DeploymentManager.CS.targets, the target GenerateDeploymentManagerCS renamed to GenerateBootstrapCS between 1.3 and 1.4. When 1.4 is released, I'll update this PR to use it, which should resolve the build issue. |
We should be sure to relnote this. We should also provide a less brittle way of doing this (or move this into our props/targets so that every app who wants the version number can get it easily). |
…fo.cs exactly once for all compilations (Xaml, etc)
good idea - updated the related WinAppSDK PR to simply use a property for including version info exactly once, before any compilation |
A bit of a hodgepodge PR:
Update to WASDK 1.4
Work around menu theme regression with 1.4
Eliminate WindowsAppSDK-VersionInfo.cs duplicate source warning
Remove bogus patch number
Support self-contained
Add publish profiles
Disable debug publish optimizations (inner loop)
Remove wapproj cruft