Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProvideServiceAttribute should be async for async packages #67

Open
AArnott opened this issue Jun 15, 2018 · 0 comments
Open

ProvideServiceAttribute should be async for async packages #67

AArnott opened this issue Jun 15, 2018 · 0 comments

Comments

@AArnott
Copy link
Member

AArnott commented Jun 15, 2018

Problem statement

Async packages that proffer services through their (synchronous) service providers result in the package not loading asynchronously even when that service is queried for using QueryServiceAsync.

Proposed solution

All services from an AsyncPackage should be proffered with the IsAsyncQueryable flag and registered with a Task-returning service factory (even if the factory itself is implemented synchronously) to ensure the package is loaded asynchronously.

AArnott added a commit that referenced this issue Apr 14, 2022
Get WPF inner-builds to import NuGet packages' imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant