Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer to encourage canceling work on shutdown #230

Open
AArnott opened this issue Aug 10, 2023 · 0 comments
Open

Analyzer to encourage canceling work on shutdown #230

AArnott opened this issue Aug 10, 2023 · 0 comments
Labels
Analyzer proposal good first issue Good for newcomers

Comments

@AArnott
Copy link
Member

AArnott commented Aug 10, 2023

Problem statement

Too much code in Visual Studio runs expensive, async work that slows down IDE shutdown.

Proposed solution

A new analyzer that ensures all JoinableTaskFactory.SwitchToMainThreadAsync calls pass in a CancellationToken (or None or default), with a fix offered to pass in VsShellUtilities.ShutdownToken. The analyzer should only activate when the VsShellUtilities.ShutdownToken symbol is available to the compilation.
AArnott added a commit that referenced this issue Feb 3, 2024
@AArnott
Merge pull request #230 from AArnott/sdkUpdate8
966c44a 
Bump to the .NET 8.0.100 SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Analyzer proposal good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AArnott