Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8800] Emit comments after open braces #9367

Closed

Conversation

HerringtonDarkholme
Copy link
Contributor

Fixes #8800

Comments after open braces are neither leading comments of statments nor trailing comments of block.
This pull request compensates missing comments after writing braces.

@msftclas
Copy link

Hi @HerringtonDarkholme, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@HerringtonDarkholme
Copy link
Contributor Author

@mhegazy would you like have a look on this, if you're available?

@mhegazy
Copy link
Contributor

mhegazy commented Sep 13, 2016

@HerringtonDarkholme extremely sorry for the long delay. got busy with TS 2.0 for a while.
With #5595, unfortunately this PR is obsolete. The bug persists though; It would be great if you can "port" this change to the new emitter. Since moving this to the new emitter is tantamount to rewriting it, I will go ahead and close this PR. again sorry for the long delay, hopefully future PRs would not have to sit for this long before being merged in.

@mhegazy mhegazy closed this Sep 13, 2016
@HerringtonDarkholme HerringtonDarkholme deleted the comment branch October 18, 2016 06:25
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants