Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tuple name inference for Iterator.next et al #59360

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

rbuckton
Copy link
Member

This updates our definitions of Iterator, Generator, AsyncIterator, and AsyncGenerator to leverage the tuple name inference change from #59045, as requested in #58243 (comment)

@rbuckton rbuckton requested review from sandersn and jakebailey July 19, 2024 17:59
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 19, 2024
@jakebailey
Copy link
Member

Hm, the thread there seems to imply that there should be some inferred named changed, but none show in the baselines?

@rbuckton
Copy link
Member Author

The change is primarily observed in quickinfo/signature help, as is shown in the tests in #59045.

@rbuckton
Copy link
Member Author

I can add a fourslash test to illustrate this

@rbuckton rbuckton merged commit 7f978c7 into main Jul 19, 2024
32 checks passed
@rbuckton rbuckton deleted the iterator-next-args branch July 19, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants