Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Array.fromAsync to esnext #57748

Merged
merged 8 commits into from
Mar 19, 2024
Merged

Conversation

iisaduan
Copy link
Member

fixes #50803

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 12, 2024
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Promise types in parameters should probably be PromiseLikes,
and a couple of typos.

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In utilities.ts there's a function called getScriptTargetFeatures that recommends using the appropriate lib setting when someone accesses values that don't seem to exist. Can you update that?

@iisaduan iisaduan merged commit 3282ff2 into microsoft:main Mar 19, 2024
26 checks passed
@iisaduan iisaduan deleted the arrayFromAsync branch March 19, 2024 17:43
@iisaduan iisaduan restored the arrayFromAsync branch March 19, 2024 18:04
@iisaduan iisaduan deleted the arrayFromAsync branch March 27, 2024 21:30
@imcotton
Copy link
Contributor

@iisaduan
Copy link
Member Author

iisaduan commented Sep 3, 2024

@imcotton thanks for finding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Array.fromAsync in lib.esnext.d.ts
5 participants