Remove nonNullUnknownType #57665

jakebailey · 2024-03-06T19:21:26Z

As far as I can tell (and test), this unknown variant is no longer needed. Probably due to the changes to how unknown is more or less {} | undefined | null.

This effectively finishes reverting #45575; most of it was removed in #49119 (as expected). By the numbers, #45575 added the declaration of and 5 uses of nonNullUnknownType, #49119 removed 3 references, and this PR removes the 2 remaining references and declaration.

jakebailey · 2024-03-06T19:29:06Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this faster

typescript-bot · 2024-03-06T19:29:07Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top200`	✅ Started	✅ Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-03-06T19:50:12Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/57665/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-03-06T19:52:36Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-03-06T20:05:58Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,557k (± 0.01%)}	_{295,578k (± 0.01%)}	_~	_295,540k	_295,602k	_{p=0.229 n=6}
_{Parse Time}	_{2.66s (± 0.19%)}	_{2.66s (± 0.19%)}	_~	_2.66s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{0.83s (± 0.00%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.071 n=6}
_{Check Time}	_{8.23s (± 0.10%)}	_{8.20s (± 0.12%)}	_{-0.02s (- 0.28%)}	_8.19s	_8.22s	_{p=0.008 n=6}
_{Emit Time}	_{7.11s (± 0.21%)}	_{7.10s (± 0.29%)}	_~	_7.09s	_7.14s	_{p=0.325 n=6}
_{Total Time}	_{18.83s (± 0.08%)}	_{18.80s (± 0.14%)}	_{-0.04s (- 0.19%)}	_18.77s	_18.82s	_{p=0.015 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,340k (± 0.92%)}	_{193,193k (± 0.99%)}	_~	_191,417k	_195,016k	_{p=0.378 n=6}
_{Parse Time}	_{1.36s (± 1.26%)}	_{1.36s (± 0.40%)}	_~	_1.35s	_1.36s	_{p=0.675 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.35s (± 0.42%)}	_{9.36s (± 0.73%)}	_~	_9.26s	_9.44s	_{p=0.688 n=6}
_{Emit Time}	_{2.61s (± 0.42%)}	_{2.61s (± 0.66%)}	_~	_2.58s	_2.63s	_{p=0.672 n=6}
_{Total Time}	_{14.04s (± 0.28%)}	_{14.05s (± 0.50%)}	_~	_13.96s	_14.14s	_{p=0.872 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,368k (± 0.00%)}	_{347,338k (± 0.01%)}	_{-31k (- 0.01%)}	_347,309k	_347,358k	_{p=0.020 n=6}
_{Parse Time}	_{2.47s (± 0.33%)}	_{2.48s (± 0.61%)}	_~	_2.46s	_2.49s	_{p=0.930 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.174 n=6}
_{Check Time}	_{6.97s (± 0.43%)}	_{6.93s (± 0.34%)}	_~	_6.91s	_6.96s	_{p=0.061 n=6}
_{Emit Time}	_{4.07s (± 0.58%)}	_{4.07s (± 0.57%)}	_~	_4.04s	_4.10s	_{p=1.000 n=6}
_{Total Time}	_{14.45s (± 0.30%)}	_{14.41s (± 0.26%)}	_~	_14.36s	_14.47s	_{p=0.225 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,754k (± 0.01%)}	_{302,767k (± 0.00%)}	_~	_302,754k	_302,776k	_{p=0.199 n=6}
_{Parse Time}	_{2.01s (± 0.58%)}	_{2.02s (± 1.97%)}	_~	_1.95s	_2.07s	_{p=0.514 n=6}
_{Bind Time}	_{1.00s (± 1.03%)}	_{1.00s (± 0.41%)}	_~	_1.00s	_1.01s	_{p=0.924 n=6}
_{Check Time}	_{6.36s (± 0.27%)}	_{6.35s (± 0.31%)}	_~	_6.31s	_6.36s	_{p=0.357 n=6}
_{Emit Time}	_{3.60s (± 0.11%)}	_{3.60s (± 0.42%)}	_~	_3.59s	_3.63s	_{p=0.858 n=6}
_{Total Time}	_{12.97s (± 0.17%)}	_{12.97s (± 0.32%)}	_~	_12.89s	_13.01s	_{p=1.000 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,236k (± 0.01%)}	_{511,226k (± 0.01%)}	_~	_511,181k	_511,357k	_{p=0.575 n=6}
_{Parse Time}	_{2.66s (± 0.45%)}	_{2.66s (± 0.65%)}	_~	_2.63s	_2.68s	_{p=0.558 n=6}
_{Bind Time}	_{0.98s (± 0.42%)}	_{0.99s (± 0.90%)}	_~	_0.98s	_1.00s	_{p=0.086 n=6}
_{Check Time}	_{17.25s (± 0.80%)}	_{17.28s (± 0.34%)}	_~	_17.22s	_17.38s	_{p=0.747 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.90s (± 0.69%)}	_{20.93s (± 0.29%)}	_~	_20.85s	_21.03s	_{p=0.630 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{2,296,328k (± 0.00%)}	_{2,296,330k (± 0.00%)}	_~	_2,296,306k	_2,296,361k	_{p=0.810 n=6}
_{Parse Time}	_{11.93s (± 0.59%)}	_{12.07s (± 0.69%)}	_{+0.14s (+ 1.17%)}	_11.95s	_12.15s	_{p=0.031 n=6}
_{Bind Time}	_{2.65s (± 0.46%)}	_{2.65s (± 0.32%)}	_~	_2.63s	_2.65s	_{p=0.867 n=6}
_{Check Time}	_{102.11s (± 0.63%)}	_{102.02s (± 0.54%)}	_~	_101.34s	_102.92s	_{p=1.000 n=6}
_{Emit Time}	_{0.32s (± 1.27%)}	_{0.32s (± 1.60%)}	_~	_0.32s	_0.33s	_{p=0.595 n=6}
_{Total Time}	_{117.01s (± 0.52%)}	_{117.05s (± 0.48%)}	_~	_116.45s	_118.04s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,394,496k (± 0.01%)}	_{2,394,356k (± 0.01%)}	_~	_2,394,019k	_2,394,530k	_{p=0.378 n=6}
_{Parse Time}	_{5.04s (± 0.40%)}	_{5.07s (± 1.24%)}	_~	_4.98s	_5.15s	_{p=0.295 n=6}
_{Bind Time}	_{1.89s (± 1.13%)}	_{1.88s (± 0.78%)}	_~	_1.87s	_1.91s	_{p=0.741 n=6}
_{Check Time}	_{33.58s (± 0.29%)}	_{33.67s (± 0.22%)}	_~	_33.60s	_33.76s	_{p=0.077 n=6}
_{Emit Time}	_{2.67s (± 1.27%)}	_{2.66s (± 1.05%)}	_~	_2.62s	_2.69s	_{p=0.810 n=6}
_{Total Time}	_{43.20s (± 0.29%)}	_{43.29s (± 0.25%)}	_~	_43.14s	_43.45s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{414,407k (± 0.01%)}	_{414,441k (± 0.01%)}	_~	_414,378k	_414,497k	_{p=0.173 n=6}
_{Parse Time}	_{2.81s (± 0.39%)}	_{2.81s (± 1.05%)}	_~	_2.78s	_2.86s	_{p=0.934 n=6}
_{Bind Time}	_{1.06s (± 0.84%)}	_{1.07s (± 0.38%)}	_~	_1.06s	_1.07s	_{p=0.086 n=6}
_{Check Time}	_{15.17s (± 0.53%)}	_{15.17s (± 0.28%)}	_~	_15.09s	_15.21s	_{p=0.873 n=6}
_{Emit Time}	_{1.11s (± 1.79%)}	_{1.11s (± 1.78%)}	_~	_1.07s	_1.12s	_{p=0.742 n=6}
_{Total Time}	_{20.15s (± 0.41%)}	_{20.15s (± 0.33%)}	_~	_20.06s	_20.25s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,859,965k (± 0.00%)}	_{2,859,948k (± 0.00%)}	_~	_2,859,822k	_2,859,994k	_{p=0.810 n=6}
_{Parse Time}	_{10.76s (± 0.28%)}	_{10.78s (± 0.49%)}	_~	_10.71s	_10.85s	_{p=0.332 n=6}
_{Bind Time}	_{3.44s (± 0.44%)}	_{3.44s (± 0.30%)}	_~	_3.42s	_3.45s	_{p=0.869 n=6}
_{Check Time}	_{61.04s (± 0.22%)}	_{61.19s (± 0.57%)}	_~	_60.70s	_61.73s	_{p=0.297 n=6}
_{Emit Time}	_{16.28s (± 0.99%)}	_{16.86s (± 8.21%)}	_~	_16.25s	_19.69s	_{p=0.810 n=6}
_{Total Time}	_{91.51s (± 0.24%)}	_{92.26s (± 1.65%)}	_~	_91.19s	_95.28s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{397,000k (± 0.01%)}	_{397,111k (± 0.02%)}	_{+111k (+ 0.03%)}	_397,035k	_397,192k	_{p=0.008 n=6}
_{Parse Time}	_{3.14s (± 0.55%)}	_{3.12s (± 0.55%)}	_~	_3.10s	_3.15s	_{p=0.059 n=6}
_{Bind Time}	_{1.37s (± 1.07%)}	_{1.38s (± 0.99%)}	_~	_1.36s	_1.40s	_{p=0.401 n=6}
_{Check Time}	_{13.96s (± 0.34%)}	_{13.98s (± 0.38%)}	_~	_13.92s	_14.05s	_{p=0.520 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.47s (± 0.25%)}	_{18.47s (± 0.31%)}	_~	_18.41s	_18.55s	_{p=1.000 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,150k (± 0.01%)}	_{513,109k (± 0.01%)}	_~	_513,070k	_513,142k	_{p=0.092 n=6}
_{Parse Time}	_{3.28s (± 0.32%)}	_{3.27s (± 0.42%)}	_~	_3.25s	_3.29s	_{p=1.000 n=6}
_{Bind Time}	_{1.54s (± 0.00%)}	_{1.54s (± 0.64%)}	_~	_1.53s	_1.56s	_{p=1.000 n=6}
_{Check Time}	_{2.86s (± 0.78%)}	_{2.85s (± 0.44%)}	_~	_2.84s	_2.87s	_{p=0.255 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.76s (± 0.28%)}	_{7.75s (± 0.16%)}	_~	_7.72s	_7.75s	_{p=0.392 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

fatcerberus · 2024-03-06T20:08:15Z

Probably due to the changes to how unknown is more or less {} | undefined | null.

Oh no - I hope it's not distributive like boolean 👀

Andarist · 2024-03-06T20:28:00Z

Oh no - I hope it's not distributive like boolean 👀

It's not :D although internally such a type kinda exists (unknownUnionType) - I don't think it's particularly special though, it's just a literal internal creation of a union that contains those 3 types

typescript-bot · 2024-03-06T20:41:28Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/57665/merge:

Everything looks good!

jakebailey · 2024-03-15T21:48:45Z

@typescript-bot user test this
@typescript-bot pack this

typescript-bot · 2024-03-15T21:48:48Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`user test this`	✅ Started	✅ Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-03-15T21:53:43Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160449/artifacts?artifactName=tgz&fileId=EBAF0A0102E43BF68F69F9828C9B1C0EA5D2370B5487E56CA4D2969AA0AEE1CD02&fileName=/typescript-5.5.0-insiders.20240315.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-57665-10".;

typescript-bot · 2024-03-15T22:09:34Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/57665/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"

Otherwise...

Everything looks good!

jakebailey · 2024-03-15T22:11:37Z

(I intentionally merged before the above result; I was just testing that a recent change in the error deltas repo was working.)

Remove nonNullUnknownType

1e2f963

typescript-bot assigned jakebailey Mar 6, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 6, 2024

jakebailey requested review from weswigham and gabritto March 14, 2024 00:10

gabritto approved these changes Mar 14, 2024

View reviewed changes

jakebailey merged commit 21c7f1c into microsoft:main Mar 15, 2024
19 checks passed

jakebailey deleted the remove-nonNullUnknownType branch March 15, 2024 21:58

jakebailey mentioned this pull request Mar 15, 2024

Fix baselines after baseline change in main #57798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove nonNullUnknownType #57665

Remove nonNullUnknownType #57665

jakebailey commented Mar 6, 2024 •

edited

Loading

jakebailey commented Mar 6, 2024

typescript-bot commented Mar 6, 2024 •

edited

Loading

typescript-bot commented Mar 6, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Mar 6, 2024

typescript-bot commented Mar 6, 2024

tsc

fatcerberus commented Mar 6, 2024

Andarist commented Mar 6, 2024

typescript-bot commented Mar 6, 2024

jakebailey commented Mar 15, 2024

typescript-bot commented Mar 15, 2024 •

edited

Loading

typescript-bot commented Mar 15, 2024 •

edited

Loading

typescript-bot commented Mar 15, 2024

jakebailey commented Mar 15, 2024

Remove nonNullUnknownType #57665

Remove nonNullUnknownType #57665

Conversation

jakebailey commented Mar 6, 2024 • edited Loading

jakebailey commented Mar 6, 2024

typescript-bot commented Mar 6, 2024 • edited Loading

typescript-bot commented Mar 6, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Mar 6, 2024

typescript-bot commented Mar 6, 2024

tsc

fatcerberus commented Mar 6, 2024

Andarist commented Mar 6, 2024

typescript-bot commented Mar 6, 2024

jakebailey commented Mar 15, 2024

typescript-bot commented Mar 15, 2024 • edited Loading

typescript-bot commented Mar 15, 2024 • edited Loading

typescript-bot commented Mar 15, 2024

jakebailey commented Mar 15, 2024

jakebailey commented Mar 6, 2024 •

edited

Loading

typescript-bot commented Mar 6, 2024 •

edited

Loading

typescript-bot commented Mar 15, 2024 •

edited

Loading

typescript-bot commented Mar 15, 2024 •

edited

Loading