Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark more options as affecting errors/resolution #53403

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Mark more options as affecting errors/resolution #53403

merged 8 commits into from
Sep 19, 2023

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Mar 21, 2023 •
edited
Loading

Fixes #53391

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 21, 2023
@jakebailey jakebailey marked this pull request as ready for review May 4, 2023 22:51
@jakebailey jakebailey requested a review from sheetalkamat May 4, 2023 22:51
sheetalkamat
sheetalkamat requested changes May 5, 2023
View reviewed changes
src/compiler/commandLineParser.ts Show resolved Hide resolved
src/compiler/commandLineParser.ts Show resolved Hide resolved
@jakebailey jakebailey mentioned this pull request May 8, 2023
Closed
@sheetalkamat sheetalkamat mentioned this pull request Jun 28, 2023
Merged
sheetalkamat
sheetalkamat requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left responses after looking at the example. It would be good to add the repro giving by daniel as a test and handle "allowJs" correctly.

sheetalkamat
sheetalkamat requested changes Sep 19, 2023
View reviewed changes
tests/baselines/reference/tscWatch/programUpdates/when-changing-`checkJs`-of-config-file.js Outdated
@@ -0,0 +1,170 @@
currentDirectory:: /user/username/projects/myproject useCaseSensitiveFileNames: false
Input::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this baseline be deleted as its outdated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, oops. Didn't see CI!

@sheetalkamat
Copy link
Member

Do you mind commenting in "jsx" commandline option why affectsSemanticDIagnostics is needed apart from module resolution affects flag so we dont have to investigate it again.

@jakebailey
Copy link
Member Author

Updated with a comment.

@jakebailey jakebailey merged commit 1a68590 into microsoft:main Sep 19, 2023
@jakebailey jakebailey deleted the fix-53391 branch September 19, 2023 22:11
snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023
@jakebailey @sheetalkamat @snovader
Mark more options as affecting errors/resolution (microsoft#53403)
45bf165 
Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
@jakebailey jakebailey mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@jakebailey jakebailey

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsx, checkJs, and possibly more options must be tracked as affectsSemanticDiagnostics
4 participants
@jakebailey @sheetalkamat @DanielRosenwasser @typescript-bot