Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big[U]Int64Array.at returns bigint, not number #46733

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Big[U]Int64Array.at returns bigint, not number #46733

merged 1 commit into from
Nov 8, 2021

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Nov 8, 2021

bigint is needed to represent all 64-bit ints that these arrays could contain.

Breaks jsdom and jsreport-core on DT, and any package that depends on es2022 and @types/node

@sandersn
Big[U]Int64Array.at returns bigint, not number
be10ba2 
bigint is needed to represent all 64-bit ints that these arrays could
contain.
@sandersn sandersn requested review from orta and weswigham November 8, 2021 17:14
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 8, 2021
orta
orta approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍🏻

weswigham
weswigham approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types are in fact just wrong, function returns a bigint at runtime.

@sandersn sandersn merged commit 9713cc1 into main Nov 8, 2021
@sandersn sandersn deleted the fix-BigIntArray-at-types branch November 8, 2021 17:50
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
@sandersn @mprobst
Big[U]Int64Array.at returns bigint, not number (microsoft#46733)
2e462bf 
bigint is needed to represent all 64-bit ints that these arrays could
contain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@orta orta orta approved these changes

Assignees

@sandersn sandersn

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandersn @orta @weswigham @typescript-bot