Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support class.hasInstance proposal (Stage 1) #46578

Closed

Conversation

Jack-Works
Copy link
Contributor

@Jack-Works Jack-Works commented Oct 29, 2021

Implements proposal: https://github.com/tc39/proposal-class-brand-check

Type check

image

Transform

image

Errors

image

Todos / known problems

  • Add test
  • For a class with generics, it will provide a guard of Class<T> instead of Class<any> or unknown

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 29, 2021
@XGHeaven
Copy link

@typescript-bot pack this

@Jack-Works Jack-Works force-pushed the proposal-class-hasInstance branch from 1c92a72 to 3d315d6 Compare February 1, 2022 13:21
@Jack-Works
Copy link
Contributor Author

I have updated this PR to reflect the latest proposal.

@Jack-Works Jack-Works force-pushed the proposal-class-hasInstance branch from c8284be to fe68c37 Compare September 23, 2022 16:09
@Jack-Works
Copy link
Contributor Author

close for now. I'll re-open and rebase this once the proposal get advanced.

@Jack-Works Jack-Works closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants