Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ts-toolbelt): recursive iteration types #33810

Merged
merged 4 commits into from
Dec 5, 2019
Merged

test(ts-toolbelt): recursive iteration types #33810

merged 4 commits into from
Dec 5, 2019

Conversation

millsp
Copy link
Contributor

@millsp millsp commented Oct 4, 2019 •
edited
Loading

Added a test for recursive iteration types to preserve ts-toolbelt's recursion capabilities in the future (as discussed with @sandersn)

@msftclas
Copy link

msftclas commented Oct 4, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@millsp
Copy link
Contributor Author

millsp commented Oct 4, 2019

I believe the build is failing because of master. Will retry when master is passing its tests again.

sandersn
sandersn approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with two comments:

  1. @weswigham recently changed the user test format. @weswigham can you make sure this is valid?
  2. Do you mind commenting at the top that this library is most widely used in ramda?

@millsp
Copy link
Contributor Author

millsp commented Oct 15, 2019

Thanks @sandersn.

I just added it.

@millsp millsp requested a review from sandersn November 30, 2019 11:46
@millsp
Copy link
Contributor Author

millsp commented Nov 30, 2019

Hey @sandersn, is this still going to be merged? Or is there anything blocking it?

@sandersn
Copy link
Member

sandersn commented Dec 5, 2019

Sorry, I lost track of this. Thanks for the ping.

@sandersn sandersn merged commit 9a766c3 into microsoft:master Dec 5, 2019
@millsp
Copy link
Contributor Author

millsp commented Dec 5, 2019

I can imagine all the stuff you've got on your list. No worries! Thanks for merging 🎉

@millsp millsp mentioned this pull request Dec 13, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millsp @msftclas @sandersn