Include all flow nodes made within try blocks as antecedents for catch or finally blocks
#29466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch` or `finally` blocks
ajafff
reviewed
Jan 17, 2019
| // We hook the creation of all flow nodes within the `try` scope and store them so we can add _all_ of them | ||
| // as possible antecedents of the start of the `catch` or `finally` blocks. | ||
| // Don't bother intercepting the call if there's no finally or catch block that needs the information | ||
| if (node.catchClause || node.finallyBlock) { |
There was a problem hiding this comment.
Does this condition make sense? It's only false if there is a syntax error.
There was a problem hiding this comment.
We still parse code with syntax errors 🤷♂️
src/compiler/binder.ts
Outdated
| bind(node.catchClause); | ||
| addAntecedent(preFinallyLabel, currentFlow); | ||
|
|
||
| flowAfterCatch = currentFlow; | ||
| } | ||
| if (node.finallyBlock) { | ||
| // We add the nodes within the `try` block to te `finally`'s antecedents if there's no catch block |
ahejlsberg
approved these changes
Jan 18, 2019
errendir
added a commit
to errendir/TypeScript
that referenced
this pull request
Jan 20, 2019
* origin/master: (64 commits) Fix resolution of properties from prototype assignment in JS (microsoft#29302) Include all flow nodes made within `try` blocks as antecedents for `catch` or `finally` blocks (microsoft#29466) Don't treat interfaces as implementations Make the relationship between partial mapped types and the empty object not apply for subtype relationship (microsoft#29384) Add missing arity check on second inference pass (microsoft#29386) renames add missing type annotation PR feedback Illustrate a case that isn't handled correctly Add fourslash tests Consider JSX namespace imports when moving statements between files Fix gulp builds not building some targets Update user baselines (microsoft#29444) Add opt-in user preference for prefix and suffix text on renames (microsoft#29314) Fake up value declaration for synthetic jsx children symbol so they get excess property checked (microsoft#29359) Add regression test. (microsoft#29433) Elaborate jsx children elementwise (microsoft#29264) Add regression test PR feedback Fix trailing whitespace ...
errendir
added a commit
to errendir/TypeScript
that referenced
this pull request
Jan 20, 2019
* origin/master: (64 commits) Fix resolution of properties from prototype assignment in JS (microsoft#29302) Include all flow nodes made within `try` blocks as antecedents for `catch` or `finally` blocks (microsoft#29466) Don't treat interfaces as implementations Make the relationship between partial mapped types and the empty object not apply for subtype relationship (microsoft#29384) Add missing arity check on second inference pass (microsoft#29386) renames add missing type annotation PR feedback Illustrate a case that isn't handled correctly Add fourslash tests Consider JSX namespace imports when moving statements between files Fix gulp builds not building some targets Update user baselines (microsoft#29444) Add opt-in user preference for prefix and suffix text on renames (microsoft#29314) Fake up value declaration for synthetic jsx children symbol so they get excess property checked (microsoft#29359) Add regression test. (microsoft#29433) Elaborate jsx children elementwise (microsoft#29264) Add regression test PR feedback Fix trailing whitespace ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28153 (And removes a TODO)