Unable to rename the property of destructuring assignment

[falsandtru]

Rename a to b.

function f({a}: {a}) {
    f({a});
}

expected:

function f({b}: {b}) {
    f({b});
}

actual:

// rename the variable
function f({b}: {a}) {
    f({b});
}
// rename the declaration
function f({a}: {b}) {
    f({b});
}

[mhegazy]

Please check the repro in #6459 (comment) as well.

[falsandtru]

I was able to reproduce that problem.

// renamed `A#foo` to `A#bar`
class A {
  bar: string;
}

class B {
  syntax1(a: A): void {
    let { foo } = a; // error, should be `{ bar }`
  }
  syntax2(a: A): void {
    let { bar: foo } = a;
  }
}

[RyanCavanaugh]

Another repro courtesy of @falsandtru that we should add tests for:

Code

Rename var a to var c in a.ts.

// a.ts
export var a;
// b.ts
import {a} from './a';
export {a}

Expected behavior:

import {c} from './a';
export {c}

Actual behavior:

import {c} from './a';
export {a}

[sheetalkamat]

Another repro from test cases found during fixing this about destructuring assignment:

interface I {
    property1: number;
    property2: string;
}
var elems: I[];

var p2;
for ({ /*This should be referenced too*/property1 : p2 } of elems) {
}

[ghost]

This still does not work reliably. For example:

const x = 1;
const o = { x };
{
    const { x } = o;
    x;
}

Renaming any x will result in broken code.

[mhegazy]

leaving this issue and using #15787 to track the change.