Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolated declarations quick fix explicitly prints out default type arguments #58449

Closed
DanielRosenwasser opened this issue May 6, 2024 · 0 comments · Fixed by #59665
Closed

Isolated declarations quick fix explicitly prints out default type arguments #58449

DanielRosenwasser opened this issue May 6, 2024 · 0 comments · Fixed by #59665
Labels
Domain: Isolated Declarations Related to the --isolatedDeclarations compiler flag Experience Enhancement Noncontroversial enhancements Help Wanted You can do this Suggestion An idea for TypeScript
Milestone
Backlog

Comments

@DanielRosenwasser
Copy link
Member 

// @declaration: true
// @isolatedDeclarations: true

export interface Foo<T, U = T[]> {
}

export function /**/foo(x: Foo<string>) {
    return x;
}

Request a quick fix at /**/.

Current:

Add return type 'Foo<string, string[]>'.

Expected:

Add return type 'Foo<string>'.
@DanielRosenwasser DanielRosenwasser mentioned this issue May 6, 2024
Open
@RyanCavanaugh RyanCavanaugh added Suggestion An idea for TypeScript Help Wanted You can do this Experience Enhancement Noncontroversial enhancements labels May 6, 2024
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone May 6, 2024
@weswigham weswigham added the Domain: Isolated Declarations Related to the --isolatedDeclarations compiler flag label May 14, 2024
@robpalme robpalme mentioned this issue Jun 20, 2024
Open
1 task
blickly added a commit to blickly/TypeScript that referenced this issue Aug 17, 2024
@blickly
Create a few (failing) test cases of microsoft#58449
dd29423
blickly added a commit to blickly/TypeScript that referenced this issue Aug 17, 2024
@blickly
Add functionality to convert a ReferenceType into a "minimal" TypeNode
1493b44 
This is the TypeNode representation of a ReferenceType that includes
the minimal number of typeArguments that are still semantically equivalent
to the full type.

Also use this functionality in the isolatedDeclaration autofixer to
fix microsoft#58449
blickly added a commit to blickly/TypeScript that referenced this issue Aug 17, 2024
@blickly
Add functionality to convert a ReferenceType into a "minimal" TypeNode
6f8e37d 
This is the TypeNode representation of a ReferenceType that includes
the minimal number of typeArguments that are still semantically equivalent
to the full type.

Also use this functionality in the isolatedDeclaration autofixer to
fix microsoft#58449
@blickly blickly mentioned this issue Aug 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: Isolated Declarations Related to the --isolatedDeclarations compiler flag Experience Enhancement Noncontroversial enhancements Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Drop unnecessary type arguments in the isolated declarations quick fix blickly/TypeScript
3 participants
@DanielRosenwasser @weswigham @RyanCavanaugh