Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to definition doesn't work #38239

Closed
OscarGodson opened this issue Apr 29, 2020 · 7 comments
Closed

Jump to definition doesn't work #38239

OscarGodson opened this issue Apr 29, 2020 · 7 comments
Labels
Duplicate An existing issue was already created

Comments

@OscarGodson
Copy link

Version: 1.44.2
Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
Date: 2020-04-16T17:07:18.473Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

Steps to Reproduce:

  1. Make a simple vanilla JS file
  2. Try to go to the definition of anything on the prototype

Does this issue occur when all extensions are disabled?: Yes

Here's my code:

var SomeThing = function (options) {
	this.something()
}

SomeThing.prototype.something = function () {
	// ... do stuff
}

When i try to go to the definition of this.something() I get an error saying "no definition found for something". This works in other editors I've used such as WebStorm/IntelliJ. It also worked at least a long time ago on Sublime when I used it. I understand that some things like globals might fail because you can't tell where it's coming from but this is a vanilla JS file where 100% of the definitions are defined in there. Even if a global was defined elsewhere this would be overriding it.

I saw some others report this but those issues were closed about a year ago.

@vscodebot
Copy link

vscodebot bot commented Apr 29, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@OscarGodson
Copy link
Author

Yes, VSCode Bot, same issue but it needed more info

@mjbvz mjbvz self-assigned this Apr 29, 2020
@mjbvz mjbvz transferred this issue from microsoft/vscode Apr 29, 2020
@mjbvz mjbvz removed their assignment Apr 29, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Apr 29, 2020

Seemed like a duplicate of #18171

@OscarGodson
Copy link
Author

Out of curiosity, I've noticed in some other reports of this people mention TypeScript and I saw this get moved. What does TypeScript have to do with it?

@DanielRosenwasser
Copy link
Member

TypeScript powers the JavaScript experience in VS Code.

@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. labels Apr 29, 2020
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.0 milestone Apr 29, 2020
@DanielRosenwasser DanielRosenwasser removed Bug A bug in TypeScript Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. labels Apr 29, 2020
@DanielRosenwasser DanielRosenwasser added the Duplicate An existing issue was already created label Apr 29, 2020
@DanielRosenwasser DanielRosenwasser removed this from the TypeScript 4.0 milestone Apr 29, 2020
@DanielRosenwasser
Copy link
Member

Yeah, looks like a dupe of #38239.

@typescript-bot
Copy link
Collaborator

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

5 participants